- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sage.rings.abc: Add pAdicRing, pAdicField; deprecate is_pAdic... #32750
Comments
Commit: |
Branch pushed to git repo; I updated commit sha1. New commits:
|
This comment has been minimized.
This comment has been minimized.
Author: Matthias Koeppe |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:7
Added missing imports in src/sage/modular/overconvergent/genus0.py and src/sage/schemes/hyperelliptic_curves/constructor.py. Hopefully this passes patchbot now; the rest of the changes looked good to me. New commits:
|
comment:8
Thanks for fixing this! |
comment:9
The remaining failure, from |
comment:10
|
comment:13
Rebased on top of |
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
|
comment:15
Merged #32665 to resolve merge conflict. |
Dependencies: #32665 |
comment:16
If we are touching this line anyway, we might as well add the second space before + elif isinstance(base, sage.rings.abc.pAdicField): # change base to Qpbar Once done, you can put it on positive review on my behalf. |
Reviewer: Jonathan Kliem |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Changed author from Matthias Koeppe to Matthias Koeppe, Alexander Galarraga |
comment:18
Thank you! |
Changed branch from u/mkoeppe/sage_rings_abc__add_padicring__padicfield__deprecate_is_padic___ to |
, sagemath#24483, sagemath#24371, sagemath#24511, sagemath#25848, sagemath#26105, sagemath#28481, sagemath#29010, sagemath#29412, sagemath#30332, sagemath#30372, sagemath#31345, sagemath#32375, sagemath#32606, sagemath#32610, sagemath#32612, sagemath#32641, sagemath#32660, sagemath#32750, sagemath#32869, sagemath#33602 <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36307 Reported by: Matthias Köppe Reviewer(s):
This change will allow use to eliminate imports from
sage.rings.padics
insage.rings.polynomial.polynomial_element
.Part of Meta-ticket #32414.
Depends on #32665
CC: @EnderWannabe @bhutz
Component: refactoring
Author: Matthias Koeppe, Alexander Galarraga
Branch/Commit:
03b24bd
Reviewer: Jonathan Kliem
Issue created by migration from https://trac.sagemath.org/ticket/32750
The text was updated successfully, but these errors were encountered: