Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta-ticket: Gitpod usability improvements #33113

Open
mkoeppe opened this issue Jan 3, 2022 · 33 comments
Open

Meta-ticket: Gitpod usability improvements #33113

mkoeppe opened this issue Jan 3, 2022 · 33 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 3, 2022

sage: polytopes.cube().show()
Launched html viewer for Graphics3d Object
sage: polytopes.regular_polygon(5).show()
Launched png viewer for Graphics object consisting of 7 graphics primitives

CC: @tobiasdiez @dimpase

Component: user interface

Issue created by migration from https://trac.sagemath.org/ticket/33113

@mkoeppe mkoeppe added this to the sage-9.5 milestone Jan 3, 2022
@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 4, 2022

Changed dependencies from #33103 to #30677, #33103

@tobiasdiez

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Jan 8, 2022
@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe changed the title gitpod usability improvements Meta-ticket: Gitpod usability improvements Feb 14, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 14, 2022

Changed dependencies from #30677, #33103 to none

@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 17, 2022

comment:18

Ticket branches are often based on an older beta version. Given that we build on top of the Docker image for the current beta version (dev), shouldn't we attempt to merge the branch into the base of the Docker image and build that?

@tobiasdiez
Copy link
Contributor

comment:19

Isn't this what the prebuild at gitpod is essentially doing?

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 2, 2022

comment:21

Replying to @tobiasdiez:

Isn't this what the prebuild at gitpod is essentially doing?

No, it's not merging. It's building the top of the branch.

@tobiasdiez
Copy link
Contributor

comment:22

Then I don't understand what you mean. The docker image used by gitpod is the same for all branches.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 2, 2022

comment:23

Yes, it is, and it is based on the latest beta.

The branch that is being tested, however, may be based on a much older beta. When building this branch, it will downgrade packages to the versions recorded in that older beta.

@tobiasdiez
Copy link
Contributor

comment:24

Yes, that's the current behavior, right? So what are you proposing to improve there?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 30, 2022

comment:25

As I said in comment:18, to merge the current branch into the branch from which the Docker image has been built.

@tobiasdiez

This comment has been minimized.

@tobiasdiez
Copy link
Contributor

comment:27

Replying to @mkoeppe:

As I said in comment:18, to merge the current branch into the branch from which the Docker image has been built.

So you want to merge the develop branch into the branch that is open in gitpod?

Note also that gitpod prebuild the branch when a new commit arrives. Thus the docker image used is the one that had been published when the branch had its last commit.

@tobiasdiez

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 30, 2022

comment:29

Replying to @tobiasdiez:

Replying to @mkoeppe:

As I said in comment:18, to merge the current branch into the branch from which the Docker image has been built.

So you want to merge the develop branch into the branch that is open in gitpod?

Technically not the develop branch but the ref from which the Docker image has been built. Most of the times, that's the same.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 30, 2022

comment:30

Replying to @tobiasdiez:

Note also that gitpod prebuild the branch when a new commit arrives. Thus the docker image used is the one that had been published when the branch had its last commit.

Yes, that's fine.

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 May 3, 2022
@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Sep 19, 2022
@mkoeppe mkoeppe removed this from the sage-9.8 milestone Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants