Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify bool and richcmp #35480

Closed
wants to merge 16 commits into from

Conversation

mantepse
Copy link
Collaborator

bool should return True if we know that the stream is non-zero, and False otherwise. The behaviour of equality should be similar. This simplifies things enormously.

This is a fork of #35429 which is a (non-working) attempt to make zero recognition more clever.

📚 Description

Fixes #35071

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe removed this from the sage-10.0 milestone May 4, 2023
@github-actions
Copy link

github-actions bot commented Sep 2, 2023

Documentation preview for this PR (built with commit dde4c7e; changes) is ready! 🎉

@mantepse
Copy link
Collaborator Author

see #35485

@mantepse mantepse closed this Sep 19, 2023
@mantepse mantepse deleted the simplify_bool_and_richcmp branch September 19, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implicit definition of combinatorial species fails
2 participants