Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify bool and richcmp #35480

Closed
wants to merge 16 commits into from
Closed

Simplify bool and richcmp #35480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
21098f0
simplify bool and make uninitialized streams nonzero unless they are …
mantepse Apr 3, 2023
bbe2ddd
add (currently failing) original doctest
mantepse Apr 3, 2023
deff76a
make equality never raise an error, return False if undecidable
mantepse Apr 6, 2023
afecec6
correct check for commutativity when selecting Cauchy product
mantepse Apr 6, 2023
f4e3204
fix commutativity issue
mantepse Apr 6, 2023
d3a7051
be slightly smarter with Cauchy multiplication
mantepse Apr 7, 2023
541d751
remove useless non-commutative case
mantepse Apr 11, 2023
27198de
polish, introduce equaltiy for Stream_function
mantepse Apr 11, 2023
8f66f14
Merge branch 'develop' into simplify_bool_and_richcmp
mantepse Apr 11, 2023
0b582ae
add doctest for codecov
mantepse Apr 11, 2023
521aa44
Merge branch 'simplify_bool_and_richcmp' of github.com:mantepse/sage …
mantepse Apr 11, 2023
8818d4a
Merge branch 'develop' of github.com:mantepse/sage into simplify_bool…
mantepse Aug 17, 2023
716d673
unify docstrings and uncontroversial doctests from #35480 and #35485
mantepse Aug 20, 2023
b8d27da
remove wrong __bool__, further consolidate with #35485
mantepse Aug 20, 2023
c3958a7
Merge branch 'develop' of https://github.com/sagemath/sage into simpl…
mantepse Aug 21, 2023
dde4c7e
Merge branch 'develop' into simplify_bool_and_richcmp
mantepse Sep 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/sage/combinat/species/recursive_species.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,15 @@ def define(self, x):
[1, 2, 3, 5, 8, 13, 21, 34, 55, 89]
sage: F.isotype_generating_series()[0:10]
[1, 2, 3, 5, 8, 13, 21, 34, 55, 89]

Check that :issue:`35071` is fixed::

sage: X = species.SingletonSpecies()
sage: E = species.SetSpecies(max=3)
sage: B = species.CombinatorialSpecies(min=1)
sage: B.define(X*E(B))
sage: B.generating_series()
z + z^2 + 3/2*z^3 + 5/2*z^4 + 9/2*z^5 + 17/2*z^6 + 133/8*z^7 + O(z^8)
"""
if not isinstance(x, GenericCombinatorialSpecies):
raise TypeError("x must be a combinatorial species")
Expand Down
Loading