Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] Fixing flaky test - TC: SALEOR_106 Issue gift card with specific customer and expiry date #4848

Merged
merged 3 commits into from
May 10, 2024

Conversation

yellowee
Copy link
Contributor

@yellowee yellowee commented May 8, 2024

What type of PR is this?

  • 💅 Refactor
  • 🌟 Feature
  • 🔥 Bug Fix
  • 🔩 Maintenance
  • 🛠 Workflow CI/CD changes

Related Issues or Documents

  • closes #

Usage Instructions, Screenshots, Recordings

Have you written tests?

  • Yes!
  • No... here is why: Writing tests are mandatory, please replace this text with why test are not included in this PR

[Optional] Description

@yellowee yellowee self-assigned this May 8, 2024
Copy link

changeset-bot bot commented May 8, 2024

🦋 Changeset detected

Latest commit: 1c5e2d9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to pr-4848 May 8, 2024 10:26 Destroyed
@yellowee yellowee marked this pull request as ready for review May 8, 2024 10:46
@yellowee yellowee requested review from a team as code owners May 8, 2024 10:46
@yellowee yellowee force-pushed the QA_fix_flaky_test_TC_SALEOR_106 branch from 4f0100a to 7877900 Compare May 8, 2024 10:47
@github-actions github-actions bot temporarily deployed to pr-4848 May 8, 2024 10:50 Destroyed
@yellowee yellowee force-pushed the QA_fix_flaky_test_TC_SALEOR_106 branch from 7877900 to d429a04 Compare May 8, 2024 12:24
@github-actions github-actions bot temporarily deployed to pr-4848 May 8, 2024 12:26 Destroyed
@yellowee yellowee force-pushed the QA_fix_flaky_test_TC_SALEOR_106 branch from d429a04 to 9e4bf0f Compare May 8, 2024 12:45
@github-actions github-actions bot temporarily deployed to pr-4848 May 8, 2024 12:47 Destroyed
@yellowee yellowee marked this pull request as draft May 8, 2024 13:04
@yellowee yellowee force-pushed the QA_fix_flaky_test_TC_SALEOR_106 branch from 9e4bf0f to 2b51f50 Compare May 9, 2024 06:18
@github-actions github-actions bot temporarily deployed to pr-4848 May 9, 2024 06:20 Destroyed
@yellowee yellowee force-pushed the QA_fix_flaky_test_TC_SALEOR_106 branch from 2b51f50 to 8c300ed Compare May 9, 2024 06:53
@github-actions github-actions bot temporarily deployed to pr-4848 May 9, 2024 06:54 Destroyed
@yellowee yellowee marked this pull request as ready for review May 9, 2024 07:07
@yellowee yellowee marked this pull request as draft May 9, 2024 13:37
@yellowee yellowee force-pushed the QA_fix_flaky_test_TC_SALEOR_106 branch from 8c300ed to d449870 Compare May 10, 2024 06:17
@github-actions github-actions bot temporarily deployed to pr-4848 May 10, 2024 06:19 Destroyed
@yellowee yellowee marked this pull request as ready for review May 10, 2024 06:43
@yellowee yellowee requested a review from karola312 May 10, 2024 06:43
@yellowee yellowee requested a review from Cloud11PL May 10, 2024 06:54
Cloud11PL
Cloud11PL previously approved these changes May 10, 2024
playwright/tests/giftCards.spec.ts Outdated Show resolved Hide resolved
@yellowee yellowee requested a review from Cloud11PL May 10, 2024 07:32
@github-actions github-actions bot temporarily deployed to pr-4848 May 10, 2024 07:32 Destroyed
Cloud11PL
Cloud11PL previously approved these changes May 10, 2024
@yellowee yellowee force-pushed the QA_fix_flaky_test_TC_SALEOR_106 branch 4 times, most recently from 46af5a8 to 3e26163 Compare May 10, 2024 08:04
@github-actions github-actions bot temporarily deployed to pr-4848 May 10, 2024 08:06 Destroyed
@yellowee yellowee requested a review from Cloud11PL May 10, 2024 08:21
@yellowee yellowee marked this pull request as draft May 10, 2024 08:21
Co-authored-by: Wojciech Mista <wojciech.mista@hotmail.com>
@yellowee yellowee merged commit 06678d0 into main May 10, 2024
15 checks passed
@yellowee yellowee deleted the QA_fix_flaky_test_TC_SALEOR_106 branch May 10, 2024 10:23
Copy link

cypress bot commented May 10, 2024

2 failed and 1 flaky tests on run #6193 ↗︎

2 212 6 0 Flakiness 1

Details:

Triggered via release - CORE 3.19.41-a4cfe18,
Project: Saleor Commit: c7e124f3c2
Status: Failed Duration: 09:10 💡
Started: May 20, 2024 3:29 PM Ended: May 20, 2024 3:38 PM
Failed  discounts/sales/createSalesForProducts.js • 1 failed test • UI - Electron

View Output

Test Artifacts
As an admin I want to create sale for products > should be able to create fixed price discount. TC: SALEOR_1802 Screenshots
Failed  products/productsList/columnPicker.js • 1 failed test • UI - Electron

View Output

Test Artifacts
As an admin I should be able to use column picker > should be able to remove dynamic column from picker on products list. TC: SALEOR_2611 Screenshots
Flakiness  cypress/e2e/discounts/sales/createSalesForProducts.js • 1 flaky test • UI - Electron

View Output

Test Artifacts
As an admin I want to create sale for products > should be able to create percentage discount. TC: SALEOR_1801 Screenshots

Review all test suite changes for PR #4848 ↗︎

karola312 pushed a commit that referenced this pull request May 23, 2024
… customer and expiry date (#4848)

* adding staff member CRUD tests

* Fixing flaky test - TC: SALEOR_106 Issue gift card with specific customer and expiry date

* Update playwright/tests/giftCards.spec.ts

Co-authored-by: Wojciech Mista <wojciech.mista@hotmail.com>

---------

Co-authored-by: Wojciech Mista <wojciech.mista@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants