-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QA] Fixing flaky test - TC: SALEOR_106 Issue gift card with specific customer and expiry date #4848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1c5e2d9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yellowee
force-pushed
the
QA_fix_flaky_test_TC_SALEOR_106
branch
from
May 8, 2024 10:47
4f0100a
to
7877900
Compare
yellowee
force-pushed
the
QA_fix_flaky_test_TC_SALEOR_106
branch
from
May 8, 2024 12:24
7877900
to
d429a04
Compare
yellowee
force-pushed
the
QA_fix_flaky_test_TC_SALEOR_106
branch
from
May 8, 2024 12:45
d429a04
to
9e4bf0f
Compare
yellowee
force-pushed
the
QA_fix_flaky_test_TC_SALEOR_106
branch
from
May 9, 2024 06:18
9e4bf0f
to
2b51f50
Compare
yellowee
force-pushed
the
QA_fix_flaky_test_TC_SALEOR_106
branch
from
May 9, 2024 06:53
2b51f50
to
8c300ed
Compare
…omer and expiry date
yellowee
force-pushed
the
QA_fix_flaky_test_TC_SALEOR_106
branch
from
May 10, 2024 06:17
8c300ed
to
d449870
Compare
Cloud11PL
previously approved these changes
May 10, 2024
Cloud11PL
previously approved these changes
May 10, 2024
yellowee
force-pushed
the
QA_fix_flaky_test_TC_SALEOR_106
branch
4 times, most recently
from
May 10, 2024 08:04
46af5a8
to
3e26163
Compare
Co-authored-by: Wojciech Mista <wojciech.mista@hotmail.com>
yellowee
force-pushed
the
QA_fix_flaky_test_TC_SALEOR_106
branch
from
May 10, 2024 08:23
3e26163
to
1c5e2d9
Compare
karola312
approved these changes
May 10, 2024
Cloud11PL
approved these changes
May 10, 2024
2 failed and 1 flaky tests on run #6193 ↗︎
Details:
discounts/sales/createSalesForProducts.js • 1 failed test • UI - Electron
products/productsList/columnPicker.js • 1 failed test • UI - Electron
cypress/e2e/discounts/sales/createSalesForProducts.js • 1 flaky test • UI - Electron
Review all test suite changes for PR #4848 ↗︎ |
karola312
pushed a commit
that referenced
this pull request
May 23, 2024
… customer and expiry date (#4848) * adding staff member CRUD tests * Fixing flaky test - TC: SALEOR_106 Issue gift card with specific customer and expiry date * Update playwright/tests/giftCards.spec.ts Co-authored-by: Wojciech Mista <wojciech.mista@hotmail.com> --------- Co-authored-by: Wojciech Mista <wojciech.mista@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Related Issues or Documents
Usage Instructions, Screenshots, Recordings
Have you written tests?
[Optional] Description