Create Auth API #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
orzechdev
force-pushed
the
refactor/user-auth
branch
from
475fd68
to
3b0d38e
Compare
krzysztofwolski
approved these changes
Jun 2, 2020
orzechdev
force-pushed
the
refactor/user-auth
branch
from
076fc28
to
1562257
Compare
orzechdev
force-pushed
the
refactor/user-auth
branch
from
1562257
to
008a8d9
Compare
orzechdev
force-pushed
the
refactor/user-auth
branch
11 times, most recently
from
a1bbc60
to
d201935
Compare
orzechdev
force-pushed
the
refactor/user-auth
branch
from
d201935
to
bc1e11f
Compare
dominik-zeglen
suggested changes
Jun 8, 2020
| @@ -1,29 +1,81 @@ | |||
| import React, { useMemo, useState } from "react"; | |||
| import React, { useEffect, useMemo, useState } from "react"; | |||
| import { persistCache } from "apollo-cache-persist"; | |||
There was a problem hiding this comment.
I don't think that we want to pin sdk user to persisted cache
There was a problem hiding this comment.
Ok, I have added to the createSaleorCache() function the code, which persists cache in local storage only if parameter persistCache is set to true. Also, check out updated readme.md file for a better explanation. Is it the right solution now?
orzechdev
force-pushed
the
refactor/user-auth
branch
3 times, most recently
from
d2ecb4f
to
9cf1a30
Compare
orzechdev
force-pushed
the
refactor/user-auth
branch
from
9cf1a30
to
195698a
Compare
orzechdev
force-pushed
the
refactor/user-auth
branch
from
df48e1b
to
7c9e331
Compare
dominik-zeglen
approved these changes
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It moves main auth functionality entirely to sdk.
It adds the following
useAuth()hook to the SDK: