This repository has been archived by the owner on Jul 14, 2022. It is now read-only.
Refactor/sdk user auth #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orzechdev
added
wip
5 tasks
orzechdev
force-pushed
the
refactor/sdk-error-handling
branch
from
add5d02
to
ef92ffe
Compare
orzechdev
force-pushed
the
refactor/sdk-user-auth
branch
from
83a7cc1
to
3216ea8
Compare
orzechdev
force-pushed
the
refactor/sdk-user-auth
branch
from
9fa444a
to
71fee67
Compare
|
Deploy preview for saleor-storefront-stage processing. Building with commit be7493a https://app.netlify.com/sites/saleor-storefront-stage/deploys/5ed1396c7a8ae80007563809 |
orzechdev
force-pushed
the
refactor/sdk-user-auth
branch
from
4fab104
to
704a1ef
Compare
orzechdev
removed
blocked
orzechdev
force-pushed
the
refactor/sdk-user-auth
branch
6 times, most recently
from
046ac31
to
ed337a0
Compare
orzechdev
force-pushed
the
refactor/sdk-user-auth
branch
from
def0081
to
0d48814
Compare
orzechdev
force-pushed
the
refactor/sdk-user-auth
branch
from
a72436b
to
cd23b28
Compare
orzechdev
force-pushed
the
refactor/sdk-user-auth
branch
from
a16bb7f
to
2f2a64c
Compare
dominik-zeglen
approved these changes
Jul 14, 2020
AlicjaSzu
reviewed
Jul 14, 2020
AlicjaSzu
approved these changes
Jul 14, 2020
|
Task linked: CU-6a5vzb Clean up Auth providers in storefront |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to merge this change because it simplifies auth in storefront by replacing it entirely with auth api from sdk (saleor/saleor-sdk#4), although there are still some methods not yet replaced by sdk methods, because password and account changing methods still depend on them - and this functionality is not yet available in sdk. Those methods are going to be updated in another pull request.
Pull Request Checklist
Test Environment Config
API_URI=https://master.staging.saleor.rocks/graphql/