Skip to content
This repository has been archived by the owner on Jul 14, 2022. It is now read-only.

Add ability to change quantity in the cart #194

Merged
merged 5 commits into from
Jan 9, 2019

Conversation

piotrgrundas
Copy link
Contributor

@piotrgrundas piotrgrundas commented Jan 8, 2019

Resolves #149
Resolves #109
Resolves #148

Note that API breaks after trying to change to a quantity that is out of stock. After fixing the API I'll add some notification for the users. Also probably the cart provider will be refactored but I want to do it in a separate PR.

image
image

@piotrgrundas piotrgrundas added the wip Work in progress label Jan 8, 2019
@piotrgrundas piotrgrundas removed the wip Work in progress label Jan 8, 2019
@piotrgrundas piotrgrundas changed the title [WIP] Add ability to change quantity in the cart Add ability to change quantity in the cart Jan 8, 2019
@piotrgrundas piotrgrundas force-pushed the cart_quantity_controls branch 4 times, most recently from d3f39bf to f03453d Compare January 8, 2019 19:07
@piotrgrundas piotrgrundas force-pushed the cart_quantity_controls branch 4 times, most recently from 5cbed99 to 532d7d0 Compare January 8, 2019 19:41
CHANGELOG.md Outdated Show resolved Hide resolved
@maarcingebala maarcingebala merged commit 64af588 into master Jan 9, 2019
data: {
checkout: { id: checkoutID }
}
} = await apolloClient.query<getCheckout, getCheckoutVariables>({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dream that one day we'd get rid of this monstrosity

export class Debounce<TValue> extends React.Component<
DebounceProps<TValue>,
DebounceState<TValue>
export class DebounceChange<TValue> extends React.Component<
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.... but why?

@maarcingebala maarcingebala deleted the cart_quantity_controls branch January 10, 2019 09:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Action remove product from cart Run tslint on CI No way to reduce the item quantity in the cart
4 participants