This repository has been archived by the owner on Jul 14, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 674
Add ability to change quantity in the cart #194
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrgrundas
force-pushed
the
cart_quantity_controls
branch
from
January 8, 2019 17:44
1473851
to
232cae0
Compare
piotrgrundas
changed the title
[WIP] Add ability to change quantity in the cart
Add ability to change quantity in the cart
Jan 8, 2019
piotrgrundas
force-pushed
the
cart_quantity_controls
branch
4 times, most recently
from
January 8, 2019 19:07
d3f39bf
to
f03453d
Compare
piotrgrundas
force-pushed
the
cart_quantity_controls
branch
4 times, most recently
from
January 8, 2019 19:41
5cbed99
to
532d7d0
Compare
piotrgrundas
force-pushed
the
cart_quantity_controls
branch
from
January 8, 2019 19:45
532d7d0
to
50499d8
Compare
weronka
reviewed
Jan 9, 2019
weronka
reviewed
Jan 9, 2019
weronka
reviewed
Jan 9, 2019
maarcingebala
approved these changes
Jan 9, 2019
data: { | ||
checkout: { id: checkoutID } | ||
} | ||
} = await apolloClient.query<getCheckout, getCheckoutVariables>({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dream that one day we'd get rid of this monstrosity
export class Debounce<TValue> extends React.Component< | ||
DebounceProps<TValue>, | ||
DebounceState<TValue> | ||
export class DebounceChange<TValue> extends React.Component< |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.... but why?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #149
Resolves #109
Resolves #148
Note that API breaks after trying to change to a quantity that is out of stock. After fixing the API I'll add some notification for the users. Also probably the cart provider will be refactored but I want to do it in a separate PR.