SALTO-6582: Fix deploy error for ProfileEnrollmentPolicyRule #6498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nurdok
approved these changes
Aug 29, 2024
| @@ -202,6 +202,7 @@ const getPolicyCustomizations = (): Record<string, definitions.fetch.InstanceFet | |||
| ? { elemID: accessPolicyRuleCustomizer } | |||
| : { elemID: { extendsParent: true } }), | |||
| serviceUrl: { path: details.ruleServiceUrl ?? details.policyServiceUrl }, | |||
| allowEmptyArrays: typeName === PROFILE_ENROLLMENT_RULE_TYPE_NAME ? true : undefined, | |||
There was a problem hiding this comment.
This will fix the bug going forward, assuming users do a fetch before deploying new changes, but restoring older workspace versions would still fail. It's fine IMO to decide we're not putting more effort into it, but if we want to ensure restores work, we also need to assign an empty array when deploying this type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix deployment issue
Additional context for reviewer
The issue caused by the fact with omit
profileAttributesarray when empty, though it's required in the deployment.will add noise reduction as well.
Release Notes:
Okta_adapter:
ProfileEnrollmentPolicyRulewhenprofileAttributesis emptyUser Notifications:
Okta_adadpter:
profileAttributesarray will be added toProfileEnrollmentPolicyRulewhen empty