Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SALTO-6582: Fix deploy error for ProfileEnrollmentPolicyRule #6498

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

SALTO-6582: Fix deploy error for ProfileEnrollmentPolicyRule #6498

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/okta-adapter/src/definitions/fetch/fetch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,7 @@ const getPolicyCustomizations = (): Record<string, definitions.fetch.InstanceFet
? { elemID: accessPolicyRuleCustomizer }
: { elemID: { extendsParent: true } }),
serviceUrl: { path: details.ruleServiceUrl ?? details.policyServiceUrl },
allowEmptyArrays: typeName === PROFILE_ENROLLMENT_RULE_TYPE_NAME ? true : undefined,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will fix the bug going forward, assuming users do a fetch before deploying new changes, but restoring older workspace versions would still fail. It's fine IMO to decide we're not putting more effort into it, but if we want to ensure restores work, we also need to assign an empty array when deploying this type.

},

fieldCustomizations: {
Expand Down