feat(freebsd): add FreeBSD support

[Strade28]

No description provided.

[dafyddj]

The changes seem fine to me, but could do with being tested, no? (By which I mean adding a platform to test-kitchen)

[Strade27]

Hello, unfortunetly travis doesn’t support freebsd. I not found easy way to do that.

[dafyddj]

You could add a custom kitchen.yml, and leave it out from Travis. A manual test is better than no test, IMO.

[myoung34]

Manual tests are generally fine but they wont be run because maintainers just rely on the GH status API.

If the tests that are in place work, then the code is fine as-is, and if it works with FreeBSD then thats a bonus until travis supports that platform. Until then this is just a refactor change and freebsd is unofficially supported as far as tests/assertions are concerned

[Strade28]

Hello !
I add some local test for freebsd using kitchen-vagrant.

[aboe76]

looks good as far as I can tell

[rbjorklin]

Just a heads up that my change that just got merged might have broken this.
#33

[Strade28]

Just a heads up that my change that just got merged might have broken this.
#33

Thanks ! there is not problem with your change.

[n-rodriguez]

This command doesn't work : bundler: command not found: KITCHEN_LOCAL_YAML=.kitchen.freebsd.yml
It should be KITCHEN_LOCAL_YAML=.kitchen.freebsd.yml bundle exec kitchen test -t test_freebsd/integration

[n-rodriguez]

there is an issue in dev-server-freebsd-11 converge step :

I, [2019-06-24T14:56:15.130479 #16838]  INFO -- dev-server-freebsd-11:           ID: vault-service-init-service-running
I, [2019-06-24T14:56:15.130565 #16838]  INFO -- dev-server-freebsd-11:     Function: service.running
I, [2019-06-24T14:56:15.130695 #16838]  INFO -- dev-server-freebsd-11:         Name: vault
I, [2019-06-24T14:56:15.130781 #16838]  INFO -- dev-server-freebsd-11:       Result: False
I, [2019-06-24T14:56:15.130866 #16838]  INFO -- dev-server-freebsd-11:      Comment: Service vault has been enabled, and is dead
I, [2019-06-24T14:56:15.130948 #16838]  INFO -- dev-server-freebsd-11:      Started: 12:56:13.567798
I, [2019-06-24T14:56:15.131029 #16838]  INFO -- dev-server-freebsd-11:     Duration: 372.742 ms
I, [2019-06-24T14:56:15.131112 #16838]  INFO -- dev-server-freebsd-11:      Changes:   
I, [2019-06-24T14:56:15.131202 #16838]  INFO -- dev-server-freebsd-11:        ----------
I, [2019-06-24T14:56:15.131291 #16838]  INFO -- dev-server-freebsd-11:        vault:
I, [2019-06-24T14:56:15.131381 #16838]  INFO -- dev-server-freebsd-11:            True

dev-server-freebsd-11.log

[myii]

@Strade28 The following is a suggestion, not a requirement:

• This PR is ripe for taking advantage of our Cirrus CI integration, which supports FreeBSD.
• Examples to refer to include:
  • https://github.com/saltstack-formulas/rkhunter-formula/blob/master/.cirrus.yml
  • https://github.com/saltstack-formulas/syslog-ng-formula/blob/master/.cirrus.yml
• These can run concurrently with Travis CI, as done in the two formulas above.

Basically, leave Travis CI as-is but add a single entry for FreeBSD in Cirrus CI.

[fzipi]

@Strade28 Can you solve the conflicts so this can be merged?

[myii]

@aboe76 Can we add @dafyddj to the SaltStack Formulas contributors group? Thanks in advance.

[aboe76]

If @dafyddj sends an invite I can aprove it.

[dafyddj]

If @dafyddj sends an invite I can aprove it.

I can't invite myself, surely?

[aboe76]

@dafyddj try this page: https://github.com/orgs/saltstack-formulas/teams

[aboe76]

@UtahDave can you invite @dafyddj ?

[myii]

@aboe76 How about this?

• https://help.github.com/en/articles/inviting-users-to-join-your-organization

[aboe76]

@myii yes I know but I don't have access, I'm only a moderator.

[myii]

@Strade28 We've finally got FreeBSD Vagrant testing working in GitHub Actions but unfortunately that's come a bit too late for this PR -- I wasn't able to push the changes here since your fork is no longer available. However, I've recovered your excellent contribution and added the CI on top in #54. I had to squash your commits and do a bit of jiggling but the backbone of your work is all there.

Thanks to all of the others for their comments and reviews towards this PR.

Closing this PR since nothing else can be done here. Please continue any further discussion in #54.

[myii]

@Strade28 #54 has been merged, so the work in this PR wasn't lost in the end -- thanks again for the contribution.