feat(freebsd): add FreeBSD support (recover abandoned PR #32)

[myii]

PR progress checklist (to be filled in by reviewers)

• Changes to documentation are appropriate (or tick if not required)
• Changes to tests are appropriate (or tick if not required)
• Reviews completed

---

What type of PR is this?

Primary type

• [build] Changes related to the build system
• [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
• [ci] Changes to the continuous integration configuration
• [feat] A new feature
• [fix] A bug fix
• [perf] A code change that improves performance
• [refactor] A code change that neither fixes a bug nor adds a feature
• [revert] A change used to revert a previous commit
• [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

• [docs] Documentation changes
• [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

• Recovers abandoned PR feat(freebsd): add FreeBSD support #32
• Semi-automated using feat(vault): add FreeBSD testing (Vagrant) myii/ssf-formula#305

Describe the changes you're proposing

Build upon the work done in #32, adding FreeBSD (Vagrant) testing in GitHub Actions.

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

• Updated the README (e.g. Available states).
• Updated pillar.example.

Testing checklist

• Included in Kitchen (i.e. under state_top).
• Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
• Updated the relevant test pillar.

Additional context

[myii]

Updated the PR to use the new pre-salted Vagrant boxes as introduced here:

• feat(vagrant): use pre-salted boxes & conditional local settings myii/ssf-formula#311

[myii]

@dafyddj Finalised this PR; would you mind reviewing again and merging if all OK?

[myii]

@dafyddj So we're getting a failure here:

-----> Verifying <install-binary-freebsd-130-master-py3>...
       Loaded install_binary 
[...] WARN: Cannot find a UUID for your node.

Profile:   vault formula (install_binary)
Version:   (not specified)
Target:    ssh://vagrant@127.0.0.1:2222
Target ID:

  File /usr/local/bin/vault
     ✔  is expected to be a file
     ✔  is expected to be executable
  Command: `/usr/local/bin/vault -version`
     ✔  exit_status is expected to eq 0
     ✔  stderr is expected to be empty
     ✔  stdout is expected to match /^Vault v1.1.0 \('36aa8c8dd1936e10ebd7a4c1d412ae0e6f7900bd'\)/
  Service vault
     ×  is expected not to be installed
     expected Service vault not to be installed
     ✔  is expected not to be enabled
     ✔  is expected not to be running
  File /etc/vault/conf.d/config.json
     ✔  is expected not to be a file

Looks like we've got a regression, introduced by this commit in InSpec:

• inspec/inspec@41ea0da#diff-6d9770e6c14d27a0aee3e8d912b78d13277502d8abaee01394e1c712e2439becL166-R171

When I run it through BSDInit, it still works. So must be an issue with the newly introduced class FreeBSD10Init < ServiceManager.

[myii]

Adding these lines back in gets it working:

    def info(service_name)
      cmd = inspec.command("#{service_ctl} -e")
      return nil if cmd.exit_status != 0

      # search for the service

      srv = %r{^.*/(#{service_name}$)}.match(cmd.stdout)
      return nil if srv.nil? || srv[0].nil?

• Exits when it doesn't find the service in the service -e command output.

So our FreeBSD failures are a false-positive; this PR can still be merged, @dafyddj.

[dafyddj]

Approved. Thanks both for the work on this.

We should report that inspec issue, yes? @myii

[saltstack-formulas-travis]

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[myii]

We should report that inspec issue, yes? @myii

Already added the fix to our fork on InSpec:

• https://gitlab.com/saltstack-formulas/infrastructure/inspec/-/commit/ba8ee70a7061b75d76e78d89bdf33ee5038ce587

Which is working out fine:

• https://github.com/myii/vault-formula/runs/5666487007?check_suite_focus=true

Reported the issue and sent through a PR:

• [Regression] FreeBSD service testing always returns installed: true even when the service is not available inspec/inspec#5947
• fix(service): ensure installed: true isn't always returned on FreeBSD inspec/inspec#5948