Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win_lgpo: lgpo.set with secedit policy always generates KeyError: u'lgpo.secedit_data' #56288

Closed
lorengordon opened this issue Mar 3, 2020 · 3 comments · Fixed by #56290
Closed

win_lgpo: lgpo.set with secedit policy always generates KeyError: u'lgpo.secedit_data' #56288

lorengordon opened this issue Mar 3, 2020 · 3 comments · Fixed by #56290
Labels
Bug broken, incorrect, or confusing behavior fixed-pls-verify fix is linked, bug author to confirm fix P3 Priority 3 severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Milestone
Blocked

Comments

@lorengordon
Copy link
Contributor

Description of Issue

Running the lgpo.set execution module with a secedit policy always generates an error: KeyError: u'lgpo.secedit_data'.

This happens because set calls _write_secedit_data() which attempts to pop lgpo.secedit_data off the __context__, but set never calls _get_secedit_data() which is where it is added to context.

Setup

None really required. Just install salt. Tested both 2018.3.4 and 2019.2.3.

Steps to Reproduce Issue

C:\salt\salt-call.bat lgpo.set computer_policy="{'GuestAccountStatus': 'Enabled'}"

Versions Report

(Provided by running salt --versions-report. Please also mention any differences in master/minion versions.)
@garethgreenaway garethgreenaway added this to the Blocked milestone Mar 3, 2020
@garethgreenaway garethgreenaway added the Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged label Mar 3, 2020
@garethgreenaway
Copy link
Contributor

@twangboy Is this a known issue?

@lorengordon
Copy link
Contributor Author

I searched but found no other mentions...

lorengordon added a commit to lorengordon/salt that referenced this issue Mar 3, 2020
@lorengordon
Ensures popping lgpo.secedit_data does not throw KeyError
d1f7761 
Fixes saltstack#56288
@lorengordon lorengordon mentioned this issue Mar 3, 2020
Merged
lorengordon added a commit to lorengordon/ash-windows-formula that referenced this issue Mar 3, 2020
@lorengordon
Ensures context contains seceditdata
62e229d 
Workaround for saltstack/salt#56288
lorengordon added a commit to lorengordon/ash-windows-formula that referenced this issue Mar 3, 2020
@lorengordon
Ensures __context__ is available in imported function
7b25d3b 
Workaround for saltstack/salt#56288
lorengordon added a commit to lorengordon/ash-windows-formula that referenced this issue Mar 3, 2020
@lorengordon
Ensures secedit_data is in __context__
ce9907b 
Workaround for saltstack/salt#56288
@garethgreenaway
Copy link
Contributor

@lorengordon Thanks for the PR with tests!

@garethgreenaway garethgreenaway added Bug broken, incorrect, or confusing behavior fixed-pls-verify fix is linked, bug author to confirm fix severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around P3 Priority 3 and removed Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged labels Mar 4, 2020
lorengordon added a commit to lorengordon/ash-windows-formula that referenced this issue Mar 18, 2020
@lorengordon
Ensures secedit_data is in __context__
3f76e08 
Workaround for saltstack/salt#56288
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug broken, incorrect, or confusing behavior fixed-pls-verify fix is linked, bug author to confirm fix P3 Priority 3 severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Projects
None yet
Milestone
Blocked
Development

Successfully merging a pull request may close this issue.

Ensures popping lgpo.secedit_data does not throw KeyError lorengordon/salt
2 participants
@garethgreenaway @lorengordon