-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensures popping lgpo.secedit_data does not throw KeyError #56290
Conversation
Other "secedit" tests are actually testing `_modal_sets`...
Just added a test. Turns out this wasn't caught before because the tests were only exercising the |
@waynew Is salt still doing bug fixes to 2018.3 and 2019.2? Would it be possible to backport this? |
@lorengordon No - per https://github.com/saltstack/salt-enhancement-proposals/blob/master/accepted/0014-dev-overhaul.md (and https://docs.google.com/document/d/1DfOGVmsQaqr3rZrFqo-gf9wm1mYM-nwa5a1zROatCXQ/edit) old branches are supported, but they no longer receive active development. To receive new fixes and features one will either need to upgrade, or backport changes themselves. But to continue to receive new fixes and features, the recommended approach is to upgrade (after testing, of course). |
Ok, it's just going to be a loooooong road before 3000 stable enough for us to switch. Sigh. |
What does this PR do?
Ensures popping lgpo.secedit_data does not throw KeyError
What issues does this PR fix or reference?
Fixes #56288
Previous Behavior
See linked issue
New Behavior
Avoids a KeyError when using
lgpo.set
with secedit policiesTests written?
[NOTICE] Bug fixes or features added to Salt require tests.
Please review the test documentation for details on how to implement tests into Salt's test suite.
Yes
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.