You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description
The pip.installed state incorrectly attempts to log any exception caught from calling modules.pip.list. It appears that pip.installed's log parameter shadows the name of the global logger and calls the parameter instead, which is None by default or str (file path) if provided by the caller.
Setup & Reproduction
Install the Salt minion v3006.0. My environment is Almalinux 8.7 in Vagrant on QEMU. Install Python 3.10.11 from source. Create a pip.installed state. Then, break pip.list somehow; this issue or this one are affecting me at the moment.
on-prem machine
VM (Virtualbox, KVM, etc. please specify)
VM running on a cloud service, please be explicit and add details
container (Kubernetes, Docker, containerd, etc. please specify)
or a combination, please be explicit
jails if it is FreeBSD
classic packaging
onedir packaging
used bootstrap to install
Expected behavior
The caught exception to be properly logged with the global logger.
Versions Report
salt --versions-report
Salt Version:
Salt: 3006.0Python Version:
Python: 3.10.11 (main, Apr 14 2023, 05:57:16) [GCC 11.2.0]Dependency Versions:
cffi: 1.14.6cherrypy: Not Installeddateutil: 2.8.1docker-py: Not Installedgitdb: Not Installedgitpython: Not InstalledJinja2: 3.1.2libgit2: Not Installedlooseversion: 1.0.2M2Crypto: Not InstalledMako: Not Installedmsgpack: 1.0.2msgpack-pure: Not Installedmysql-python: Not Installedpackaging: 22.0pycparser: 2.21pycrypto: Not Installedpycryptodome: 3.9.8pygit2: Not Installedpython-gnupg: 0.4.8PyYAML: 5.4.1PyZMQ: 23.2.0relenv: 0.11.2smmap: Not Installedtimelib: 0.2.4Tornado: 4.5.3ZMQ: 4.3.4System Versions:
dist: almalinux 8.7 Stone Smilodonlocale: utf-8machine: x86_64release: 4.18.0-425.13.1.el8_7.x86_64system: Linuxversion: AlmaLinux 8.7 Stone Smilodon
The text was updated successfully, but these errors were encountered:
Description
The
pip.installed
state incorrectly attempts to log any exception caught from callingmodules.pip.list
. It appears thatpip.installed
'slog
parameter shadows the name of the global logger and calls the parameter instead, which isNone
by default orstr
(file path) if provided by the caller.Setup & Reproduction
Install the Salt minion v3006.0. My environment is Almalinux 8.7 in Vagrant on QEMU. Install Python 3.10.11 from source. Create a
pip.installed
state. Then, breakpip.list
somehow; this issue or this one are affecting me at the moment.Expected behavior
The caught exception to be properly logged with the global logger.
Versions Report
salt --versions-report
The text was updated successfully, but these errors were encountered: