Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3006.x] Fix 64169 #64171

Merged
merged 8 commits into from
May 10, 2023
Merged

[3006.x] Fix 64169 #64171

merged 8 commits into from
May 10, 2023

Conversation

vps-eric
Copy link
Contributor

@vps-eric vps-eric commented Apr 26, 2023

What does this PR do?

Calls the global log variable instead of the state parameter log when handling exceptions from pre-caching the pip list within pip.installed.

What issues does this PR fix or reference?

Fixes #64169

Merge requirements satisfied?

Commits signed with GPG?

Yes

@vps-eric vps-eric requested a review from a team as a code owner April 26, 2023 20:00
@vps-eric vps-eric requested review from whytewolf and removed request for a team April 26, 2023 20:00
@welcome
Copy link

welcome bot commented Apr 26, 2023

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject@vmware.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

salt/states/pip_state.py Outdated Show resolved Hide resolved
@dwoz dwoz requested a review from s0undt3ch April 27, 2023 21:14
Copy link
Collaborator

@s0undt3ch s0undt3ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets rename the global log object to logger instead.

@vps-eric vps-eric temporarily deployed to ci April 30, 2023 09:03 — with GitHub Actions Inactive
@vps-eric vps-eric temporarily deployed to ci April 30, 2023 09:03 — with GitHub Actions Inactive
@vps-eric vps-eric temporarily deployed to ci April 30, 2023 09:03 — with GitHub Actions Inactive
@vps-eric vps-eric temporarily deployed to ci April 30, 2023 12:00 — with GitHub Actions Inactive
@vps-eric vps-eric temporarily deployed to ci April 30, 2023 12:00 — with GitHub Actions Inactive
@vps-eric vps-eric temporarily deployed to ci April 30, 2023 12:00 — with GitHub Actions Inactive
Copy link
Collaborator

@s0undt3ch s0undt3ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request changes, but yes, this was what I was after.

Thanks!

tests/pytests/unit/states/test_pip.py Outdated Show resolved Hide resolved
tests/pytests/unit/states/test_pip.py Outdated Show resolved Hide resolved
tests/pytests/unit/states/test_pip.py Outdated Show resolved Hide resolved
s0undt3ch
s0undt3ch previously approved these changes May 1, 2023
@vps-eric vps-eric temporarily deployed to ci May 1, 2023 21:32 — with GitHub Actions Inactive
@vps-eric vps-eric temporarily deployed to ci May 1, 2023 21:35 — with GitHub Actions Inactive
@vps-eric vps-eric temporarily deployed to ci May 1, 2023 21:40 — with GitHub Actions Inactive
@vps-eric vps-eric temporarily deployed to ci May 1, 2023 23:26 — with GitHub Actions Inactive
@vps-eric vps-eric temporarily deployed to ci May 1, 2023 23:26 — with GitHub Actions Inactive
@vps-eric vps-eric temporarily deployed to ci May 1, 2023 23:26 — with GitHub Actions Inactive
@s0undt3ch
Copy link
Collaborator

Please install pre-commit and run pre-commit run -av black. See https://github.com/saltstack/salt/actions/runs/4854962886/jobs/8654893083?pr=64171#step:9:99 for background as to why.

@vps-eric vps-eric temporarily deployed to ci May 2, 2023 22:11 — with GitHub Actions Inactive
@vps-eric vps-eric temporarily deployed to ci May 2, 2023 22:11 — with GitHub Actions Inactive
@vps-eric vps-eric temporarily deployed to ci May 2, 2023 22:11 — with GitHub Actions Inactive
@vps-eric vps-eric temporarily deployed to ci May 2, 2023 23:32 — with GitHub Actions Inactive
@vps-eric vps-eric temporarily deployed to ci May 2, 2023 23:32 — with GitHub Actions Inactive
@vps-eric vps-eric temporarily deployed to ci May 2, 2023 23:32 — with GitHub Actions Inactive
@vps-eric vps-eric requested review from dwoz and s0undt3ch May 4, 2023 13:51
@vps-eric vps-eric temporarily deployed to ci May 8, 2023 15:30 — with GitHub Actions Inactive
@vps-eric vps-eric temporarily deployed to ci May 8, 2023 15:30 — with GitHub Actions Inactive
@vps-eric vps-eric temporarily deployed to ci May 8, 2023 15:30 — with GitHub Actions Inactive
@vps-eric
Copy link
Contributor Author

Just want to make sure there's nothing waiting on me for this PR. GitHub says I have changes requested from @dwoz, but I resolved that conversation?

@Ch3LL Ch3LL merged commit 8742306 into saltstack:3006.x May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants