-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3006.x] Fix 64169 #64171
[3006.x] Fix 64169 #64171
Conversation
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets rename the global log
object to logger
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Request changes, but yes, this was what I was after.
Thanks!
Please install pre-commit and run |
Just want to make sure there's nothing waiting on me for this PR. GitHub says I have changes requested from @dwoz, but I resolved that conversation? |
What does this PR do?
Calls the global
log
variable instead of the state parameterlog
when handling exceptions from pre-caching the pip list withinpip.installed
.What issues does this PR fix or reference?
Fixes #64169
Merge requirements satisfied?
Commits signed with GPG?
Yes