-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't return False when target exists (file.rename) #49843
Conversation
@MTecknology Thanks for submitting this! There's a test failing here: https://jenkinsci.saltstack.com/job/pr-kitchen-ubuntu1604-py2/job/PR-49843/1/ Can you take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good and the failing test just needs to be updated to reflect the new return value.
Please doco the change in behavior in doc/topics/releases/neon.rst On a side note, not an issue with this PR. However file.copy() has been change to file.copy_() in develop branch? Update found
No Problem. |
You can ignore that, @MTecknology, there is no need to document a bugfix in the release notes. |
We run a changelog script that adds this sort of stuff for us. |
Ahh, after reading the original issue it's clear that this was not 100% bugfix, so I'll get the change documented. |
@terminalmage Thanks! |
[master] Porting #49843 to master
What does this PR do?
This PR applies the change recommended by @DickerDackel in #49748.
Previous Behavior
When using file.rename and then creating a new file in it's place, subsequent executions will fail due to a file existing in it's place.
New Behavior
This patch removes the
False
return when a destination file exists if-force:False
.Tests written?
Yes
Commits signed with GPG?
Yes