Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't return False when target exists (file.rename) #49843

Merged
merged 2 commits into from
Oct 2, 2018
Merged

Don't return False when target exists (file.rename) #49843

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8b6e25
Don't return False when target exists. (Fixes: #49748)
MTecknology Sep 30, 2018
92645cf
Update unit test to match expected behavior change.
MTecknology Oct 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion salt/states/file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6375,7 +6375,6 @@ def rename(name, source, force=False, makedirs=False):
if not force:
ret['comment'] = ('The target file "{0}" exists and will not be '
'overwritten'.format(name))
ret['result'] = False
return ret
elif not __opts__['test']:
# Remove the destination to prevent problems later
Expand Down