Add salt_version execution module #49891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This execution module exposes Salt's release codenames as functions that can be used to make comparison's to the minion's Salt version. This is useful when writing states that handle deprecations. By exposing the release codenames, people can use these comparisons in Jinja statements in statefiles. This is only one example and the use case I wanted to cover here. There may be more that I haven't thought of, but this is a start!
gtmanfred
approved these changes
Oct 3, 2018
terminalmage
approved these changes
Oct 4, 2018
|
Am I the only one who reads |
|
@rallytime Hey! Do you plan to backport this feature to |
|
I went ahead and ported the PR: #55195 |
max-arnold
pushed a commit
to max-arnold/salt
that referenced
this pull request
Nov 15, 2019
Add salt_version execution module
dwoz
added a commit
that referenced
this pull request
Dec 3, 2019
[master] Port #49891 (salt_version module)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This execution module exposes Salt's release codenames as functions that can be used to make comparison's to the minion's Salt version.
This is useful when writing states that handle deprecations. By exposing the release codenames, people can use these comparisons in Jinja statements in state files. This is only one example and the use case I wanted to cover here. There may be more that I haven't thought of, but this is a start!
What issues does this PR fix or reference?
None that I know of.
Tests written?
Yes
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.