Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] Port #49891 (salt_version module) #55195

Merged
merged 4 commits into from
Dec 3, 2019
Merged

[master] Port #49891 (salt_version module) #55195

merged 4 commits into from
Dec 3, 2019

Conversation

max-arnold
Copy link
Contributor

@max-arnold max-arnold commented Nov 4, 2019 •
edited
Loading

Master backport of #49891 (salt_version execution module).

Also, fixed the LNAMES mocks (indexes should be lowercase, the mocked tests passed by accident) and changed the function names and semantics:

2019-11-05 at 00 06

@max-arnold max-arnold requested a review from a team as a code owner November 4, 2019 17:11
@ghost ghost requested a review from waynew November 4, 2019 17:11
@max-arnold max-arnold mentioned this pull request Nov 4, 2019
Merged
waynew
waynew suggested changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@waynew waynew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but with the change to 3000-based versions, we probably should update the docs.

salt/modules/salt_version.py Outdated Show resolved Hide resolved
salt/modules/salt_version.py Outdated Show resolved Hide resolved
@max-arnold max-arnold force-pushed the salt-version-module branch 2 times, most recently from d38bc25 to 714cb8a Compare November 5, 2019 06:58
@max-arnold max-arnold force-pushed the salt-version-module branch 2 times, most recently from fb943b3 to 525a7b9 Compare November 11, 2019 12:22
@max-arnold
Copy link
Contributor Author

@waynew Does the tweaked first paragraph look good?

@dwoz dwoz merged commit 7061018 into saltstack:master Dec 3, 2019
@max-arnold max-arnold mentioned this pull request Jan 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwoz dwoz dwoz approved these changes

@waynew waynew Awaiting requested review from waynew

Assignees
No one assigned
Labels
master-port
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@max-arnold @waynew @dwoz @gtmanfred