Fix error retry handling for Route53 #51572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwoz
reviewed
Feb 13, 2019
There was a problem hiding this comment.
@kaidokert It looks there are some failing tests related to this change. Can you take a look?
|
Checked, i'm completely lost on how any of those changes could result in these errors. It seems completely unrelated. |
|
Ok jenkins finally showed me the actual issue, linting. Cleaned up |
Akm0d
approved these changes
Jun 14, 2019
Merged
|
Ported to master in #56696 |
alexey-zhukovin
pushed a commit
to alexey-zhukovin/salt
that referenced
this pull request
Apr 29, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes error handling, as not all errors should be retried. Currently, if a wrong AWS key is used with no access, the error is not reported at all.
What issues does this PR fix or reference?
Previous Behavior
Configure
route53.keyin pillar to an invalid value, the access errors are not reportedNew Behavior
With invalid key provided, the exception is correctly raised and reported on state run
Tests written?
No
Commits signed with GPG?
No