Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port #51572 to master #56967

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Port #51572 to master #56967

merged 1 commit into from
Apr 29, 2020

Conversation

alexey-zhukovin
Copy link
Contributor

What does this PR do?

Port #51572 to master

@alexey-zhukovin alexey-zhukovin added Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases master-port labels Apr 29, 2020
@alexey-zhukovin alexey-zhukovin requested a review from a team as a code owner April 29, 2020 11:44
@ghost ghost requested review from dwoz and removed request for a team April 29, 2020 11:44
@dwoz
Copy link
Contributor

dwoz commented Apr 29, 2020

I think this one is okay to merge without adding a test.

@dwoz dwoz merged commit 04ca470 into saltstack:master Apr 29, 2020
@alexey-zhukovin alexey-zhukovin deleted the master-port-51572 branch May 5, 2020 18:15
@sagetherage sagetherage added the ZRelease-Sodium retired label label May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwoz dwoz dwoz approved these changes

Assignees
No one assigned
Labels
master-port Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases ZRelease-Sodium retired label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexey-zhukovin @dwoz @sagetherage @kaidokert