Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ES index settings methods #53737

Closed
wants to merge 3 commits into from
Closed

Conversation

Oloremo
Copy link
Contributor

@Oloremo Oloremo commented Jul 6, 2019

What does this PR do?

Added two Elasticsearch API methods:
put_settings
get_settings

To the Salt Elasticsearch module

What issues does this PR fix or reference?

#53736

Previous Behavior

These methods were not supported

New Behavior

These methods now supported

Tests written?

Yes

Commits signed with GPG?

Yes

Copy link
Contributor

@Akm0d Akm0d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks excellent. Thank your for the PR and 👍 to good tests.

@Akm0d Akm0d added the Feature new functionality including changes to functionality and code refactors, etc. label Jul 8, 2019
@Oloremo Oloremo requested a review from a team as a code owner August 13, 2019 11:23
@ghost ghost requested a review from waynew August 13, 2019 11:23
@dwoz
Copy link
Contributor

dwoz commented Dec 14, 2019

@Oloremo Can you please rebase and open the PR against master?

@Oloremo
Copy link
Contributor Author

Oloremo commented Dec 14, 2019

@dwoz yeah but it actually needs some rework since in API put_settings(**kwargs) and I don't support it here.

@Oloremo
Copy link
Contributor Author

Oloremo commented Dec 21, 2019

Backport to master: #55721

@Oloremo Oloremo closed this Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature new functionality including changes to functionality and code refactors, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants