Added ES index get_settings and put_settings methods #55721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
Oloremo
force-pushed
the
53736-added-es-index-settings
branch
4 times, most recently
from
6f1c839
to
742f33b
Compare
Oloremo
commented
Dec 21, 2019
| @@ -28,7 +28,8 @@ Versions are `MAJOR.PATCH`. | |||
|
|
|||
| ### Added | |||
|
|
|||
| - [#54917](https://github.com/saltstack/salt/pull/54917) - Added get_settings, put_settings and flush_synced methods for Elasticsearch module. - [@Oloremo](https://github.com/Oloremo) | |||
| - [#54505](https://github.com/saltstack/salt/issues/54505) - Added cluster get_settings, put_settings and flush_synced methods for Elasticsearch module. - [@Oloremo](https://github.com/Oloremo) | |||
There was a problem hiding this comment.
Updated it a bit to show that it was about cluster settings
Oloremo
force-pushed
the
53736-added-es-index-settings
branch
from
742f33b
to
6c5287a
Compare
Oloremo
force-pushed
the
53736-added-es-index-settings
branch
from
6c5287a
to
48b5b7e
Compare
|
re-run full centos7-py2 |
dwoz
approved these changes
Dec 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added two Elasticsearch API methods:
put_settings
get_settings
To the Salt Elasticsearch module
What issues does this PR fix or reference?
#53736
Previous Behavior
These methods were not supported
New Behavior
These methods now supported
Tests written?
Yes
Commits signed with GPG?
Yes