mongodb_user.present aplying changes on existing mongodb user even if Test=true #53963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of an existing user even in test mode.
…tioning when aplying state for an existing user
dbuenor
force-pushed
the
dbueno/bug-mongodb-user-present-aplying-changes-on-existing-user-even-if-testing
branch
from
7ddbe95
to
ef5be1b
Compare
|
Rejected due to new PR opened (#53965). |
dbuenor
added a commit
to dbuenor/salt
that referenced
this pull request
Jul 24, 2019
gitebra
pushed a commit
to gitebra/salt
that referenced
this pull request
Aug 30, 2019
* upstream/develop: add new saltconf ads Fix grains.core pylint error Adding Unit Tests and Fixing debian_eth.jinja Adding accept_ra 2 option to modules.debian_ip fix names to various package modules so links work adds webconfig tests Commit to fix lint problems to allow successful pr-lint build auth: use log formatting for message Refactorized mongodb_user.present to avoid showing successful changes when no changes has been made to user. Now shows changes when roles has been changed for user so its easier to see if roles going to changed in test mode. Changed tests to adapt to new behaviour. Changed returned result when using test=true for mongodb_user.present to avoid false positives. Fixed whitespaces at mongodb_user.present test saltstack#53963 Added new test for mongodb_user.present that verifies the proper functioning when aplying state for an existing user Fixes bug in MongoDb User State causing changes to be applied in case of an existing user even in test mode. auth: log details in case of user auth issue Fix typo in vault docs
waynew
pushed a commit
to waynew/salt
that referenced
this pull request
Jan 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
Fixes #53962
Previous Behavior
Apply changes to mongodb user when Test=true
New Behavior
Doesn't apply changes to mongodb user when Test=true, and shows a new debug message to notify that user is already present and it's going to be modified.
Tests written?
Yes
Commits signed with GPG?
No