Mongodb_user.present aplying changes on existing mongodb user even if Test=true #53965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbuenor
changed the title
dbuenor
force-pushed
the
dbueno/bug-mongodb-user-present-aplying-changes-on-existing-user-even-if-testing-rebased
branch
from
c468f70
to
0eb5c93
Compare
ghost
requested a review
from 
… of an existing user even in test mode.
…tioning when aplying state for an existing user
… to avoid false positives.
dbuenor
force-pushed
the
dbueno/bug-mongodb-user-present-aplying-changes-on-existing-user-even-if-testing-rebased
branch
from
0eb5c93
to
889cc14
Compare
… when no changes has been made to user. Now shows changes when roles has been changed for user so its easier to see if roles going to changed in test mode. Changed tests to adapt to new behaviour.
waynew
approved these changes
Jul 24, 2019
|
@dwoz have u been able to check if everything is fine now? Thx |
|
@dwoz ping?! |
cmcmarrow
approved these changes
Aug 23, 2019
|
Thanks @dbuenor! Sorry for the delay |
dwoz
approved these changes
Aug 23, 2019
dbuenor
deleted the
dbueno/bug-mongodb-user-present-aplying-changes-on-existing-user-even-if-testing-rebased
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes bug at mongodb_user.present modifying state to avoid apply changes when Test=true on an existing MongoDb user.
Add a new mongodb_user.present test for an existing MongoDb user
What issues does this PR fix or reference?
Fixes #53962
Previous Behavior
Apply changes to mongodb user when Test=true
New Behavior
Doesn't apply changes to mongodb user when Test=true, and shows a new debug message to notify that user is already present and it's going to be modified.
Tests written?
Yes
Commits signed with GPG?
No