Copy symlinks as symlinks in dest tree for tests #54453
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To get some information from the system, which we then use to choose the appropriate static requirements file, we need to run some commands, something that nox will refuse to do if `--install-only` is passed. We work around it by manually patching the value of `session._runner.global_config.install_only` for the commands that we MUST run, and only those and then we set it back to the value it had before. For additional information about why we have to do this, please see: wntrblm/nox#181
Note on yappi
fix typo in salt/states/archive.py
[develop] Fix static requirements
Fix test suite on develop
[develop] Workaround nox's install only flag
Add fully qualified cmd call
The etcd returner is using the wrong API due to a refactor of salt.utils.etcd_util.
external returners can blow up for any variety of reasons, but when we don't catch it it will sometimes stop the event from being returned to the bus via fire_event, which has downstream effects. so lets guard against that.
improve documentation regarding state.sls
Fix x509 typos
Updates to slsutil.banner
add new saltconf ads
fix names to various package modules so links work
Fix typo in vault docs
Fix grains.core pylint error
…t-aplying-changes-on-existing-user-even-if-testing-rebased Mongodb_user.present aplying changes on existing mongodb user even if Test=true
adds webconfig tests
…rror auth: log details in case of user auth issue
Adding accept_ra 2 option to modules.debian_ip
modifying saltconf ads
ghost
requested a review
from 
|
Closing in favor of #54900 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Instead of copying the symlinks as files in the destination tree for gitfs tests, it ensures that symlinks are copied as symlinks so that symlinks are also handled during testing.
Related issue and comment: #54402 (comment)
Commits signed with GPG?
Yes
This must generate a failure in tests to poiint out an existing missed case. It shall be merged after #54454