-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keyring param to gpg modules, final cleanup #63179
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkubb
force-pushed
the
gpg-keyring
branch
10 times, most recently
from
December 5, 2022 10:26
a6309f2
to
ef191cc
Compare
lkubb
force-pushed
the
gpg-keyring
branch
5 times, most recently
from
December 11, 2022 18:16
682604f
to
7654046
Compare
3 tasks
twangboy
requested changes
May 8, 2023
This was referenced Jul 26, 2023
@twangboy Can we still get this into 3007? This PR has celebrated its first birthday recently. |
dwoz
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
keyring
param to all functions (if sensible)gpg.absent
user
,gnupghome
andkeyring
(if sensible)Todo:
gnupghome
andkeyring
totrust_key
gpg.decrypt
test is failing on older systemsThis is based on #63162, so that one would have to be merged before.PR has been merged.What issues does this PR fix or reference?
Fixes: #59783
Previous Behavior
always uses default keyring
New Behavior
keyring can be specified
Merge requirements satisfied?
Commits signed with GPG?
Yes