Add signature verification to file.managed/archive.extracted
#63611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkubb
force-pushed
the
file-managed-gpg
branch
from
e8037eb
to
03efc32
Compare
twangboy
requested changes
May 8, 2023
lkubb
force-pushed
the
file-managed-gpg
branch
from
03efc32
to
2467198
Compare
lkubb
force-pushed
the
file-managed-gpg
branch
from
2467198
to
1369317
Compare
lkubb
force-pushed
the
file-managed-gpg
branch
from
1369317
to
0cc2797
Compare
dwoz
approved these changes
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows
file.managedandarchive.extractedto optionally require valid signatures onsourcefiles and/orsource_hashfiles.Note that this PR relies on all my previous work on thegpgmodules, the diff will be much smaller once they are merged and this one is rebased:#63168
#63162
#63179
All of them were merged and this is rebased.
What issues does this PR fix or reference?
Fixes: #63143
Previous Behavior
Signature validation is highly cumbersome (see linked issue)
New Behavior
Signature validation happens automatically, if requested
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes