[3006.x] Fix salt-ssh state.* commands retcode for render fail
#64515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
state.* commands retcode for render failstate.* commands retcode for render fail
salt-project-bot-prod-environment
bot
changed the title
state.* commands retcode for render failstate.* commands retcode for render fail
|
This looks to be ready, but you have this PR in draft mode. Am I good to review? |
|
@Ch3LL Sure! Since the SSH system is a bit convoluted, I wanted some time to consider alternative approaches, but I'm always happy to read your opinion. And if you're fine with this, so am I. :) |
Ch3LL
approved these changes
Jun 21, 2023
whytewolf
approved these changes
Jun 21, 2023
4 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ensures a state/pillar rendering failure is reported with a non-zero exit code by salt-ssh.
What issues does this PR fix or reference?
Fixes: #64514
This also adds a test that tried, but failed to reproduce #50727, and a test for general module failure retcodes.
Previous Behavior
exit(0)
New Behavior
exit(20) (the same as all other failures are reported with)
Merge requirements satisfied?
Commits signed with GPG?
Yes