Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set selected candidate pair #2

Closed
wants to merge 10 commits into from
Closed

Set selected candidate pair #2

wants to merge 10 commits into from

Conversation

sam-vi
Copy link
Owner

@sam-vi sam-vi commented Sep 4, 2023

Fixes w3c#171.

An event is proposed to defer the nomination of a candidate pair, thereby allowing the selected candidate pair to be changed without an ICE restart. A method is proposed to actually change the selected candidate pair.


Preview | Diff

This avoids a race condition where an application might cause
state to change from within an event handler.
If nomination is being deferred, either side is allowed to send
on a pair of their choosing. Only nomination is the exclusive
prerogative the controlling agent.
@alvestrand
Copy link

This is a PR from a branch to another branch - was that the intention?

@sam-vi sam-vi changed the base branch from samvi-166-pruneproposal to main October 4, 2023 13:03
@sam-vi
Copy link
Owner Author

sam-vi commented Oct 4, 2023

This is a PR from a branch to another branch - was that the intention?

This PR was stacked on top of w3c#168 before that PR was merged. It was intended to show the minimal diff for w3c#174 minus the edits in the base PR.

This PR is no longer necessary since w3c#168 is merged. w3c#174 (for merging into w3c:main) is where all discussions can take place. I'll close this PR.

@sam-vi sam-vi closed this Oct 4, 2023
@sam-vi sam-vi deleted the samvi-171-setselected branch November 13, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE improvements: select a candidate pair
2 participants