Prevent candidate pair removal #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youennf
reviewed
Jun 22, 2023
youennf
reviewed
Jun 22, 2023
jan-ivar
reviewed
Jun 22, 2023
pthatcher
reviewed
Jun 27, 2023
pthatcher
approved these changes
Jun 27, 2023
|
This issue was discussed in WebRTC June 2023 meeting – 27 June 2023 (Issue #166 PR #168 - prevent candidate pair removal) |
This slot is only needed once method(s) are added to RTCIceTransport to perform ICE actions, eg. pruneCandidatePair(). Then the slot is used to guard against performing another action while a proposal is pending resolution. So defer adding the slot until methods are added.
This event adds symmetry to the candidate pair lifecycle, so apps are informed of both candidate pair formation and pruning. The candidatepairadded event is not strictly necessary for the pruneproposed event, but makes it easier to use.
sam-vi
force-pushed
the
samvi-166-pruneproposal
branch
from
33b0a65 to
96eb5fd
Compare
|
This issue was mentioned in WEBRTCWG-2023-09-12 (Page 66) |
|
Is this one ready to merge? |
henbos
approved these changes
Sep 21, 2023
jan-ivar
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #166
This is a proposal for a cancelable event approach to preventing ICE candidate pair pruning.
An event is also proposed at the formation of candidate pairs, which is not strictly necessary for preventing candidate pair pruning, but makes sense to go together for applications to have a better view of the candidate pair lifecycle.
Preview | Diff