Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If font-famliy has single quotes, the font family is not working. #186

Closed
bitgenerator opened this issue Oct 18, 2024 · 2 comments
Closed
Labels
enhancement New feature or request

Comments

@bitgenerator
Copy link

bitgenerator commented Oct 18, 2024

If Comic Sans MS is added via lunasvg_add_font_face_from_data as "Comic Sans MS" and an editor like InkScape is refering to this font in style as font-family:'Comic Sans MS', the font is not rendered. I need to add the font as "'Comic Sans MS'" to the function. So, somehow single quotes parsing is missing,

@sammycage sammycage added the enhancement New feature or request label Oct 18, 2024
@sammycage
Copy link
Owner

sammycage commented Oct 18, 2024

Thanks for pointing this out! I’ve fixed the issue by adding support for font-family names with quotes. lunasvg should now handle font-family: 'Comic Sans MS' correctly. Let me know if it works for you!

@bitgenerator
Copy link
Author

Looks good :-) Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants