-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake modernization #84
Conversation
To use targets and properties so that lunasvg can be more easily added to external projects using cmake's FetchContent.
Based upon feedback.
Cmake modernization
Wonderful work... I'll take a closer look. <3 |
Have you had a chance to take a look at this please? |
|
I think it's fine. It just helps put the build artifacts under install dir/bin install dir/include etc. It worked for me on Windows anyway.
Ah right. This header file is generated into the build dir when you run cmake. The line that generates it is:
It just saves us hand crafting a suitable export header for shared/static libs. The full documentation is at: https://cmake.org/cmake/help/latest/module/GenerateExportHeader.html Hope this helps! :) |
Good job. This is an important change. Hope it lands at some point :) |
Thank you, @seanharmer. I apologize for the delay in responding. |
These changes makes it much easier to use lunasvg in downstream projects either by hand or via CMake's FetchContent.