🎁 remove whitespaces from CSV headers #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/samvera-labs/bulkrax into handle-whitepaces-in-csv-headers
…/samvera-labs/bulkrax into handle-whitepaces-in-csv-headers
ShanaLMoore
commented
Jun 13, 2023
…/samvera-labs/bulkrax into handle-whitepaces-in-csv-headers
…/samvera-labs/bulkrax into handle-whitepaces-in-csv-headers
…-labs/bulkrax into handle-whitepaces-in-csv-headers
…/samvera-labs/bulkrax into handle-whitepaces-in-csv-headers
TODO:look into and resolve failing specs |
ShanaLMoore
commented
Jun 21, 2023
| @@ -20,7 +20,7 @@ def self.read_data(path) | |||
| raise StandardError, 'CSV path empty' if path.blank? | |||
| options = { | |||
| headers: true, | |||
| header_converters: ->(h) { h.to_sym }, | |||
| header_converters: ->(h) { h.to_s.strip.to_sym }, | |||
There was a problem hiding this comment.
🙈 @jeremyf this is a much better implementation! thank you!
alishaevn
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before this code, I spent a lot of time confused about why my importer wasn't working. I couldn't find any helpful errors to assist. It turns out the failure was because my CSV accidentally had a white space in one of its headers. "parents " instead of "parents". This code will remove any white spaces in the headers.
Screenshots / Video
AFTER
Expected Behavior