Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎁 remove whitespaces from CSV headers #816

Merged
merged 14 commits into from
Jun 26, 2023
Merged

🎁 remove whitespaces from CSV headers #816

Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
a3550ea
:gift: remove whitespaces from CSV headers
ShanaLMoore Jun 13, 2023
b0cd0f6
:gift: remove whitespaces from CSV headers
ShanaLMoore Jun 13, 2023
10120fe
Merge branch 'handle-whitepaces-in-csv-headers' of https://github.com…
ShanaLMoore Jun 13, 2023
a7851a4
Merge branch 'handle-whitepaces-in-csv-headers' of https://github.com…
ShanaLMoore Jun 13, 2023
d2a6b79
Merge branch 'handle-whitepaces-in-csv-headers' of https://github.com…
ShanaLMoore Jun 13, 2023
15fad21
Merge branch 'handle-whitepaces-in-csv-headers' of https://github.com…
ShanaLMoore Jun 13, 2023
90b98a7
Merge branch 'handle-whitepaces-in-csv-headers' of https://github.com…
ShanaLMoore Jun 13, 2023
52934a9
Merge branch 'main' into handle-whitepaces-in-csv-headers
ShanaLMoore Jun 14, 2023
30f8ac2
:broom: remove accidental debugging statement
ShanaLMoore Jun 14, 2023
75e3007
:broom: remove accidental debugging statement
ShanaLMoore Jun 14, 2023
195eca3
Merge branch 'handle-whitepaces-in-csv-headers' of github.com:samvera…
ShanaLMoore Jun 14, 2023
039eb6e
Merge branch 'main' into handle-whitepaces-in-csv-headers
ShanaLMoore Jun 16, 2023
fd8fce0
Merge branch 'handle-whitepaces-in-csv-headers' of https://github.com…
ShanaLMoore Jun 16, 2023
626d1da
♻️ Favoring `header_converters` for CSV to remove blanks
jeremyf Jun 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/models/bulkrax/csv_entry.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def self.read_data(path)
raise StandardError, 'CSV path empty' if path.blank?
options = {
headers: true,
header_converters: ->(h) { h.to_sym },
header_converters: ->(h) { h.to_s.strip.to_sym },
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈 @jeremyf this is a much better implementation! thank you!

encoding: 'utf-8'
}.merge(csv_read_data_options)

Expand Down