Contact page - customizable email to per tenant #1622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I100 contact us See merge request notch8/hyku-up!32
|
are there changes from this we'd like to port back to Hyrax, especially to help avoid the copied-code situation? i think maybe opening up |
no-reply
pushed a commit
to samvera/hyrax
that referenced
this pull request
Jun 17, 2020
since the `ContactForm` model doesn't use `ActiveRecord`, it can be easily subclassed and customized. allowing the controller to use a configured/injected model helps avoid the need for hard monkeypatches in downstream apps; see, e.g. samvera/hyku#1622
|
@no-reply yes, seems like a good call going forward. I'm tempted to get this merged and open a ticket for it as part of the broader upgrade task set. |
|
oh yeah. i definitely wouldn't delay this on upstream improvements. just wanting to set you up for a cleaner solution down the road. |
no-reply
pushed a commit
to samvera/hyrax
that referenced
this pull request
Jun 17, 2020
since the `ContactForm` model doesn't use `ActiveRecord`, it can be easily subclassed and customized. allowing the controller to use a configured/injected model helps avoid the need for hard monkeypatches in downstream apps; see, e.g. samvera/hyku#1622
dewey4iv
approved these changes
Jun 17, 2020
no-reply
pushed a commit
to samvera/hyrax
that referenced
this pull request
Jun 17, 2020
since the `ContactForm` model doesn't use `ActiveRecord`, it can be easily subclassed and customized. allowing the controller to use a configured/injected model helps avoid the need for hard monkeypatches in downstream apps; see, e.g. samvera/hyku#1622
jeremyf
approved these changes
Jun 22, 2020
|
Approved, but I don't want to merge as I won't have space to further help out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1207 #517
Split settings of default contact page email "from" and email "to". There is a Hyrax.config.contact_email as well, but we really need both a "from" and a "to" email address and we want to be able to set both from ENV.
Override Hyrax default so that the from address isn't whatever is put in the form, as many MTAs do now allow non-specified from addresses. Instead include the contact page email in the reply-to and the subject.
Allow changing the "to" email address on a per tenant basis. Provides an admin form for a given tenant to set where they want contact emails to be sent to.
@samvera/hyrax-code-reviewers
Please note contribution for this PR comes from Hykuup.com and NYC's DORIS project