open the ContactFormController to model subclasses
#4374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangewolf
previously approved these changes
Jun 17, 2020
since the `ContactForm` model doesn't use `ActiveRecord`, it can be easily subclassed and customized. allowing the controller to use a configured/injected model helps avoid the need for hard monkeypatches in downstream apps; see, e.g. samvera/hyku#1622
no-reply
force-pushed
the
open-contact-form-cont
branch
from
9e35881
to
c09ce8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since the
ContactFormmodel doesn't useActiveRecord, it can be easilysubclassed and customized. allowing the controller to use a configured/injected
model helps avoid the need for hard monkeypatches in downstream apps; see,
e.g. samvera/hyku#1622
@samvera/hyrax-code-reviewers