Allow CreateDerivativesJob to receive either an AF object or a Valkyrie resource

[randalldfloyd]

Allow CreateDerivativesJob to receive either an ActiveFedora object or a Valkyrie resource

Descriptive summary

Convert CreateDerivativesJob to allow it to receive either an ActiveFedora based object or a Valkyrie::Resource equivalent object.

Rationale

Allow jobs to execute correctly with existing AF implementation or the Wings Valkyrie implementation.

Expected behavior

CreateDerivativesJob receives a Valkyrie::Resource and performs the action.

Actual behavior

CreateDerivativesJob raises an exception when passed a Valkyrie::Resource.

Approach for Conversion

See Pattern for Jobs Receiving Parameter that may be an AF Object or a Valkyrie Resource

Related work

These have all be modified to support AF object or Valkyrie resource using the established pattern.

• Issue Allow GrantEditToMembersJob to receive either an AF object or a Valkyrie resource as the Work #4101 Allow GrantEditToMembersJob to receive either an AF object or a Valkyrie resource as the Work (PR extract out common permission job code #4123)
• Issue Allow GrantReadToMembersJob to receive either an AF object or a Valkyrie resource as the Work #4102 Allow GrantReadToMembersJob to receive either an AF object or a Valkyrie resource as the Work (PR extract out common permission job code #4123)
• Issue Allow RevokeEditToMembersJob to receive either an AF object or a Valkyrie resource as the Work #4103 Allow RevokeReadToMembersJob to receive either an AF object or a Valkyrie resource as the Work (PR extract out common permission job code #4123)
• Issue Add GlobalID::Identification for resources passed to jobs #4099 Add GlobalID::Identification for resources passed to jobs (PR automatically convert valkyrie resource to ActiveJobProxy when enqueuing #4124)

[mjgiarlo]

May be blocked by #4060.

[hackartisan]

related work: #5540

[hackartisan]

I don't think we need to update the existing job, since currently valkyrie derivatives creation is triggered directly in the valkyrie ingest job. However, there is a discrepancy between the way derivatives and characterization are triggered that I wonder if we should align.

#5321 adds characterization via an object.file.uploaded event published by the ValkyrieIngestJob.

That was later moved to an extracted class in #5628. Note that the PR description references derivative creation, as though there's an implementation intention.

Then derivatives generation was added for valkyrie, by enqueuing a job from the ingest job, in #5540.

Was there an intention during the work on #5628 that was not fulfilled in #5540? Should the derivatives job be kicked off by a published event rather than enqueued directly? If so, there may be something to do here around negotiating which derivatives job to invoke.

[no-reply]

some discussion occurred in Slack https://samvera.slack.com/archives/CDRHAMUTV/p1692716666450449.

I don't think we need to update the existing job

i agree with this, and think it's safe to close this

[hackartisan]

Created #6162 and closing this.