Valkyrie Characterization and File attachment #5321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test `ValkyrieCharacterizationService`'s public `#run` interface.
added 2 commits
January 11, 2022 12:18
ValkyrieCharacterizationService was initially ported in from Hydra::Works and lightly modified to work with Valkyrie. the ported code was a little messy, and in want of cleanup. the public interface on `#run` is changed here to use named parameters, and some of the private methods are rewritten to harden them up. references to OM, which was removed from the Hyrax dependency tree in 2019, are removed. unused and opaque behavior around "proxied terms" is removed entirely. `#send`s are changed to `#public_send` to avoid accidentally calling private behavior (which could be injected by manipulating the mapping hash). we also add a test for publishing the metadata updates on the metadata node, and add the implementation for that.
dunn
reviewed
Jan 11, 2022
| @@ -34,6 +34,9 @@ def save(resource:) | |||
|
|
|||
| resource_factory.to_resource(object: af_object) | |||
| rescue ActiveFedora::RecordInvalid, RuntimeError => err | |||
| raise "more serious and helpful error message" if | |||
There was a problem hiding this comment.
were you going to replace this message?
dunn
approved these changes
Jan 11, 2022
This was referenced Aug 22, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds valkyrie upload handling and characterization, based on the hydra-works service class, to allow characterizing file uploads of Valkyrie objects.
replaces #5303.
@samvera/hyrax-code-reviewers