Discrepancy between Hyrax::SolrService#query and ActiveFedora::SolrService#query

[kirkkwang]

Descriptive summary

There is a discrepancy between Hyrax::SolrService#query and ActiveFedora::SolrService#query in what it returns.

Steps to reproduce the behavior in User Interface (UI)

1. Using Bulkrax, initiate an export for all records
2. See that it fails

Actual behavior (include screenshots if available)

Hyrax double_combo branch using Bulkrax hyrax-4-valkyrie-support branch

[32, 41] in /app/samvera/hyrax-webapp/gems/gems/bulkrax/app/factories/bulkrax/valkyrie_object_factory.rb
   32:     def self.query(q, **kwargs)
   33:       # TODO: Without the Hyrax::SolrService, what are we left with?  Someone could choose
   34:       # ActiveFedora::SolrService.
   35:       raise NotImplementedError, "#{self}.#{__method__}" unless defined?(Hyrax)
   36:       debugger
=> 37:       Hyrax::SolrService.query(q, **kwargs)
   38:     end
   39:
   40:     ##
   41:     # Retrieve properties from M3 model
(byebug) (q)
"has_model_ssim:(GenericWork OR Image OR GenericWorkResource OR ImageResource) "
(byebug) kwargs
{:fl=>"id,file_set_ids_ssim", :method=>:post, :rows=>2147483647}
(byebug) Hyrax::SolrService.query(q, **kwargs)
[]
(byebug) Hyrax::SolrService.query("*:*", **kwargs.merge(fq:q))
[{"id"=>"dc163b97-71dc-4efd-8fb6-c2b9021aa814"}]
(byebug) ActiveFedora::SolrService.query(q, **kwargs)
[{"id"=>"dc163b97-71dc-4efd-8fb6-c2b9021aa814"}]

Note that

Hyrax::SolrService.query(q, **kwargs) => []

while

ActiveFedora::SolrService.query(q, **kwargs) => [{"id"=>"dc163b97-71dc-4efd-8fb6-c2b9021aa814"}]

In order for a similar return value, using this seems to work

Hyrax::SolrService.query("*:*", **kwargs.merge(fq:q)) => [{"id"=>"dc163b97-71dc-4efd-8fb6-c2b9021aa814"}]

Acceptance Criteria/Expected Behavior

• Hyrax::SolrService#query should return the same thing as ActiveFedora::SolrService#query or have something similar