🐛 Restore qt: 'standard' to SolrService
#6677
Conversation
jeremyf
force-pushed
the
fix-hyrax-solr-service
branch
2 times, most recently
from
3462159
to
190550a
Compare
In `ActiveFedora::SolrService` we always assign the `qt: 'standard'`.[1] However, with [this old commit][1] we dropped passing the `qt: 'standard'` when we had `use_valkyrie` of true. We discovered this bug when upgrading Hyku and Bulkrax to Hyrax v3.x and some. Closes #6676 Related to: - #3857 [1]:https://github.com/samvera/active_fedora/blob/8e7d365a087974b4ff9b9217f792c0c049789de6/lib/active_fedora/solr_service.rb#L40-L48 [2]:be6104f
jeremyf
force-pushed
the
fix-hyrax-solr-service
branch
from
190550a
to
78abeaa
Compare
Also remove an un-tested element.
|
Perhaps it was to allow the application more flexibility when making solr queries? |
|
@dlpierce The main problem is that it means I amended the class to expose a configuration option. I did favor the configuration option that will not break existing implementations of Bulkrax and Hyku (e.g. by including My assumption is that folks using valkyrie will likely have specified a |
|
Yeah, sorry I have specific memory about that param! |
This relates to the fact that `Hyrax::SolrService` does not behave the same way (for earlier versions of Hyrax). Related to: - samvera/hyrax#6677
This relates to the fact that `Hyrax::SolrService` does not behave the same way (for earlier versions of Hyrax). Related to: - samvera/hyrax#6677
tl;dr Can anyone explain why we don't want
qt: 'standard'for Valkyrie connections?In
ActiveFedora::SolrServicewe always assign theqt: 'standard'.1However, with this old commit we dropped passing the
qt: 'standard'when we haduse_valkyrieof true.We discovered this bug when upgrading Hyku and Bulkrax to Hyrax v3.x and some.
Closes #6676
Related to:
@samvera/hyrax-code-reviewers