Improve the universal viewer deployment #3761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
This looks great. @geekscruff is there any action that needs to be taken post-merge for |
no-reply
approved these changes
Apr 26, 2019
|
@no-reply thanks! nothing for nurax, as I have a PR in to put the new files in place (those come during install which isn't re-run for nurax). |
|
ah, yeah. do we need a rake task to move files around during upgrade? |
|
@no-reply good idea, I'll get that in early next week |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on feedback from @little9 over at nurax#336
The uv install can be run with
yarn installorrake assets:precompile.I'll update the Hyrax Management Guide accordingly.
@samvera/hyrax-code-reviewers