-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add universal_viewer install task #3765
Conversation
@no_reply follow on from #3761 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there enough duplication between this and
hyrax/lib/generators/hyrax/install_generator.rb
Lines 178 to 179 in 0e02c4a
copy_file 'uv.html', 'config/uv/uv.html' | |
copy_file 'uv-config.json', 'config/uv/uv-config.json' |
yarn install
and instead instruct the user to run it (in the puts on line 13).
This issue has been automatically marked as stale because it has not had activity for 30 days. It will be closed if no further activity occurs within 14 days. Thank you for your contributions. |
@geekscruff This looks good. I think a rebase from master will downgrade valkyrie and take care of the failing bundle job in the circleci build. |
@cjcolvar green :) |
The universal_viewer installation mechanism will change in version 3. This task allows those upgrading to install universal viewer.
@samvera/hyrax-code-reviewers