Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add universal_viewer install task #3765

Merged
merged 1 commit into from
Jun 3, 2019
Merged

Add universal_viewer install task #3765

merged 1 commit into from
Jun 3, 2019

Conversation

ghost
Copy link

@ghost ghost commented Apr 29, 2019

The universal_viewer installation mechanism will change in version 3. This task allows those upgrading to install universal viewer.

@samvera/hyrax-code-reviewers

@ghost
Copy link
Author

ghost commented Apr 30, 2019

@no_reply follow on from #3761

@ghost ghost removed the in progress label May 1, 2019
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there enough duplication between this and

copy_file 'uv.html', 'config/uv/uv.html'
copy_file 'uv-config.json', 'config/uv/uv-config.json'
that it might make sense to make the rake task the definitive declaration and have the generator call this rake task? That might also include removing the explicit call to yarn install and instead instruct the user to run it (in the puts on line 13).

@stale
Copy link

stale bot commented May 31, 2019

This issue has been automatically marked as stale because it has not had activity for 30 days. It will be closed if no further activity occurs within 14 days. Thank you for your contributions.

@stale stale bot added the stale label May 31, 2019
cjcolvar
cjcolvar previously approved these changes Jun 3, 2019
@stale stale bot removed the stale label Jun 3, 2019
@cjcolvar
Copy link
Member

cjcolvar commented Jun 3, 2019

@geekscruff This looks good. I think a rebase from master will downgrade valkyrie and take care of the failing bundle job in the circleci build.

@ghost
Copy link
Author

ghost commented Jun 3, 2019

@cjcolvar green :)

@cjcolvar cjcolvar merged commit 0914819 into master Jun 3, 2019
@cjcolvar cjcolvar deleted the uv_rake branch June 3, 2019 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants