Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5794 download file redux #5987

Merged
merged 30 commits into from
Jun 12, 2023
Merged

5794 download file redux #5987

merged 30 commits into from
Jun 12, 2023

Commits on Mar 22, 2023

  1. valkyrie downloads controller

    @dlpierce @orangewolf
    dlpierce authored and orangewolf committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    54f2cdc View commit details
    Browse the repository at this point in the history

  2. Do not override existing methods and cleanup unused and duplicate code

    @dlpierce @orangewolf
    dlpierce authored and orangewolf committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    1255c2a View commit details
    Browse the repository at this point in the history

  3. WIP valk download controller spec fixes

    @dlpierce @orangewolf
    dlpierce authored and orangewolf committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    9652a0d View commit details
    Browse the repository at this point in the history

  4. handle differences between wings adapter api and direct valkarie api … 

    …in file downloads
    @orangewolf
    orangewolf committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    8b6d6af View commit details
    Browse the repository at this point in the history

  5. do not load the file in to memory unless you really have to

    @orangewolf
    orangewolf committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    5785021 View commit details
    Browse the repository at this point in the history

  6. call the cops

    @orangewolf
    orangewolf committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    402f7e0 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2023

  1. stream data, skip if etags are valid, adjust specs

    @orangewolf
    orangewolf committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    6013b67 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. valkyrie downloads controller

    @dlpierce
    dlpierce authored and tamsin johnson committed May 10, 2023
    Configuration menu
    Copy the full SHA
    e50a6a1 View commit details
    Browse the repository at this point in the history

  2. Do not override existing methods and cleanup unused and duplicate code

    @dlpierce
    dlpierce authored and tamsin johnson committed May 10, 2023
    Configuration menu
    Copy the full SHA
    5fdd383 View commit details
    Browse the repository at this point in the history

  3. WIP valk download controller spec fixes

    @dlpierce
    dlpierce authored and tamsin johnson committed May 10, 2023
    Configuration menu
    Copy the full SHA
    c0e0505 View commit details
    Browse the repository at this point in the history

  4. handle differences between wings adapter api and direct valkarie api … 

    …in file downloads
    @orangewolf
    orangewolf authored and tamsin johnson committed May 10, 2023
    Configuration menu
    Copy the full SHA
    15e1c45 View commit details
    Browse the repository at this point in the history

  5. do not load the file in to memory unless you really have to

    @orangewolf
    orangewolf authored and tamsin johnson committed May 10, 2023
    Configuration menu
    Copy the full SHA
    e9f3d0c View commit details
    Browse the repository at this point in the history

  6. call the cops

    @orangewolf
    orangewolf authored and tamsin johnson committed May 10, 2023
    Configuration menu
    Copy the full SHA
    8edd688 View commit details
    Browse the repository at this point in the history

  7. stream data, skip if etags are valid, adjust specs

    @orangewolf
    orangewolf authored and tamsin johnson committed May 10, 2023
    Configuration menu
    Copy the full SHA
    ad378b4 View commit details
    Browse the repository at this point in the history

  8. test that Range headers are ignored on HEAD requests 

    rfc9110 14.2 says:

> A server MUST ignore a Range header field received with a request method that
> is unrecognized or for which range handling is not defined. For this specification,
> GET is the only method for which range handling is defined.
    tamsin johnson committed May 10, 2023
    Configuration menu
    Copy the full SHA
    18ae46d View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. since koppie and dassie are only supported via Docker and Dockerfile … 

    …specifies Ruby version, we should not also specify in the Gemfile. Only listing it once makes it easier to update correctly and also means changing the Dockerfile ARG can actually build the app successfully.
    @orangewolf
    orangewolf committed May 23, 2023
    Configuration menu
    Copy the full SHA
    4782eb6 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2023

  1. Merge branch 'main' into 5794-download_file-redux

    @orangewolf
    orangewolf authored May 24, 2023
    Configuration menu
    Copy the full SHA
    0fc4114 View commit details
    Browse the repository at this point in the history

  2. Merge branch '5794-download_file-redux' of https://github.com/samvera… 

    …/hyrax into 5794-download_file-redux
    @orangewolf
    orangewolf committed May 24, 2023
    Configuration menu
    Copy the full SHA
    51e628a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'only_specify_ruby_version_one_time' into 5794-download_… 

    …file-redux
    @orangewolf
    orangewolf committed May 24, 2023
    Configuration menu
    Copy the full SHA
    4cae2e8 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into 5794-download_file-redux

    @aprilrieger
    aprilrieger authored May 24, 2023
    Configuration menu
    Copy the full SHA
    e5296c3 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2023

  1. Merge branch 'main' into 5794-download_file-redux

    @alishaevn
    alishaevn committed May 26, 2023
    Configuration menu
    Copy the full SHA
    051cad7 View commit details
    Browse the repository at this point in the history

  2. Merge branch '5794-download_file-redux' of https://github.com/samvera… 

    …/hyrax into 5794-download_file-redux
    @alishaevn
    alishaevn committed May 26, 2023
    Configuration menu
    Copy the full SHA
    7100138 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2023

  1. Merge branch 'main' into 5794-download_file-redux

    @alishaevn
    alishaevn committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    fe85dd1 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. use the test adapters since fcrepo adapter file writing does not work… 

    … properly in specs
    @orangewolf
    orangewolf committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    f784a5e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into 5794-download_file-redux

    @orangewolf
    orangewolf committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    4ff2b23 View commit details
    Browse the repository at this point in the history

  3. Merge branch '5794-download_file-redux' of https://github.com/samvera… 

    …/hyrax into 5794-download_file-redux
    @orangewolf
    orangewolf committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    8e78b6b View commit details
    Browse the repository at this point in the history

  4. rubocop

    @orangewolf
    orangewolf committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    8900842 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. thumbnails and other deriviatives were not stored in the path we expe… 

    …cted them to be. this was due to Valkyrie using a different pairtree method than Hyrax
    @orangewolf
    orangewolf committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    fa1be2b View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2023

  1. make sure path stays the same as previous

    @orangewolf
    orangewolf committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    e05bac3 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2023

  1. Merge pull request #6091 from samvera/5504-deriviatives-were-harder-t… 

    …o-find-than-wifes-headphones

thumbnails and other derivatives were not stored in the path we expected them to be
    @dlpierce
    dlpierce authored Jun 12, 2023
    Configuration menu
    Copy the full SHA
    5189184 View commit details
    Browse the repository at this point in the history