Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-docker: only run bundle/yarn during build #6237

Merged
merged 5 commits into from
Aug 29, 2023
Merged

dev-docker: only run bundle/yarn during build #6237

merged 5 commits into from
Aug 29, 2023

Conversation

dunn
Copy link
Contributor

@dunn dunn commented Aug 28, 2023

Fixes

Fixes #6207

@samvera/hyrax-code-reviewers

@dunn dunn requested a review from no-reply August 28, 2023 22:47
@dunn
Copy link
Contributor Author

dunn commented Aug 28, 2023

i'm not sure if .dockerignore is working correctly; when testing i had to manually delete the lockfiles when switching from koppie to dassie

@dunn dunn marked this pull request as ready for review August 29, 2023 00:29
@dlpierce
Copy link
Contributor

.dockerignore only affects the COPY action in the Dockerfile. It does not filter files when mounting a volume like we do in the compose files. And the file generated during the image build would not be available once the compose stack is up, also because of the volume mount. Instead a new one is generated, or if one already exists on the host system then it is used instead, leading to mismatches with the image's installed gems.

The real problem with the Gemfile is it is being shared by multiple environments: dassie, koppie, and the host system.

@dlpierce
Copy link
Contributor

@dunn What do you think of this arrangement? GH-6207...GH-6207-dedicated-locks

@dunn
Copy link
Contributor Author

dunn commented Aug 29, 2023

@dlpierce oh, that's a good idea

dunn and others added 4 commits August 29, 2023 18:27
@dunn
add koppie lockfile to dockerignore
357c0e7
@dunn
docker: add yarn to build step, remove from runtime
cf286c2
@dunn
ci: don't run yarn
d731b4b
@dlpierce @dunn
Use dedicated lock files for dassie/koppie
2616a51 
Tries to avoid mismatches between the image's installed gems and the lock file by not sharing the same Gemfile.lock in different contexts.
Causes bundler in docker compose to create and use Gemfile.dassie.lock or Gemfile.koppie.lock, leaving the regular Gemfile.lock for host system use.
@mcritchlow mcritchlow self-requested a review August 29, 2023 20:30
@mcritchlow mcritchlow merged commit 0aa7bf8 into main Aug 29, 2023
3 checks passed
@mcritchlow mcritchlow deleted the GH-6207 branch August 29, 2023 20:50
@dlpierce dlpierce added the notes-container Release Notes: Docker, Helm, etc label Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcritchlow mcritchlow mcritchlow approved these changes

@no-reply no-reply Awaiting requested review from no-reply

Assignees
No one assigned
Labels
notes-container Release Notes: Docker, Helm, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enusure hyrax-engine-dev builds install needed dependencies
3 participants
@dunn @dlpierce @mcritchlow