Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-docker: only run bundle/yarn during build #6237

Merged
merged 5 commits into from
Aug 29, 2023
Merged

dev-docker: only run bundle/yarn during build #6237

merged 5 commits into from
Aug 29, 2023

Commits on Aug 29, 2023

  1. add koppie lockfile to dockerignore

    @dunn
    dunn committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    357c0e7 View commit details
    Browse the repository at this point in the history

  2. docker: add yarn to build step, remove from runtime

    @dunn
    dunn committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    cf286c2 View commit details
    Browse the repository at this point in the history

  3. ci: don't run yarn

    @dunn
    dunn committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    d731b4b View commit details
    Browse the repository at this point in the history

  4. Use dedicated lock files for dassie/koppie 

    Tries to avoid mismatches between the image's installed gems and the lock file by not sharing the same Gemfile.lock in different contexts.
Causes bundler in docker compose to create and use Gemfile.dassie.lock or Gemfile.koppie.lock, leaving the regular Gemfile.lock for host system use.
    @dlpierce @dunn
    dlpierce authored and dunn committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    2616a51 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into GH-6207

    @mcritchlow
    mcritchlow committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    8500177 View commit details
    Browse the repository at this point in the history