Ability and search fixes #6653
Closed
Ability and search fixes #6653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use config variable for admin set in more places.
laritakr
force-pushed
the
collections-and-admin-set-resources
branch
2 times, most recently
from
d548dca
to
e0c1851
Compare
laritakr
force-pushed
the
collections-and-admin-set-resources
branch
from
e0c1851
to
27164f2
Compare
For collection and admin set
laritakr
force-pushed
the
collections-and-admin-set-resources
branch
from
27164f2
to
8b5cf93
Compare
Admin Sets were appearing twice, once via their gid, and once via their model. This change moves them to work like other collections.
The admin set create service cannot create an AdminSet. Changing to use the config variable causes specs to break, because they are using the default config value of AdminSet. This is the first step to locking down the change. The default fallback value to AdminSet should probably be changed as well.
The config admin set class should not fall back to AdminSet, since the default admin set service cannot create an AdminSet.
Links for Admin sets in collection type dropdown have changed.
calling wrong method
Shared specs are still failing.
Base class on config for admin_set_model rather than the use_valkyrie flag
* double_combo: ☑️ Add stubbing 🐛 Favor helper method over instance variable Extracting a collection models method 💄 endless and ever appeasing of the coppers ♻️ Stub incidental query ♻️ Consider all of the curation concerns
Throughout the code we have quite a bit of conditionals regarding what is a work, collection, file_set, and adminsitrative set. This model attempts to provide a common point to interrogate the application. There are, at present, no refactors to use this model. Consider how our specs and our application are inconsistent in their declaration/configuration/stubbing. This model should help with that.
Instead of the myriad of ways of asking about which models to use, let's leverage a consolidated central place for information. This is but one step in addressing other issues.
…n-set-resources * extract-hyrax-model-registry: 🐛 Favor helper method over instance variable Favor helper method over instance variable ♻️ Favor dynamic value ♻️ Favor helper method ☑️ Fix stubbing Adding case statement ♻️ Fixing spec ♻️ Favor Hyrax::ModelRegistry 💄 endless and ever appeasing of the coppers ♻️ Leverage Hyrax::ModelRegistry for ability tests ♻️ Favor Hyrax::ModelRegistry for search builders ♻️ Extracting naming container 🧹 Expose Hyrax.config.use_valkyrie=
kirkkwang
force-pushed
the
double_combo
branch
2 times, most recently
from
8aa7ec6
to
5d5e1f9
Compare
|
Relevant work was included elsewhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Uses config variable for admin set in more places. Allows for creating a custom resource that inherits from Hyrax::AdministrativeSet.
References config in places which were previously only hardcoded with AdminSet and Hyrax::AdministrativeSet.
Remaining specs with failures (dassie 19, dassie-valkyrie 20, koppie 11)
refs scientist-softserv/hykuup_knapsack#94