Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability and search fixes #6653

Closed
wants to merge 49 commits into from

Commits on Feb 1, 2024

  1. Ability and search fixes

    Use config variable for admin set in more places.
    laritakr committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    4e91ab9 View commit details
    Browse the repository at this point in the history
  2. Ignore rubocop's complaint

    laritakr committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    c4722e5 View commit details
    Browse the repository at this point in the history
  3. Additional use of config variables

    For collection and admin set
    laritakr committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    8b5cf93 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. Address duplication in collection type dropdown

    Admin Sets were appearing twice, once via their gid, and once via their
    model. This change moves them to work like other collections.
    laritakr committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    40f2c0e View commit details
    Browse the repository at this point in the history
  2. Fix typos and rubocop

    laritakr committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    bf33a9e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c5ce8af View commit details
    Browse the repository at this point in the history
  4. Another rubocop fix

    laritakr committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    b1e02ae View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f20540f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    4f9458e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    897bbf8 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. Resolve merge conflict

    laritakr committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    10dc1a3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    447abf4 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. Configuration menu
    Copy the full SHA
    f272c90 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Configuration menu
    Copy the full SHA
    d21129e View commit details
    Browse the repository at this point in the history
  2. Lock down AdminSetCreateService class

    The admin set create service cannot create an AdminSet. Changing to use
    the config variable causes specs to break, because they are using the
    default config value of AdminSet.
    
    This is the first step to locking down the change. The default fallback
    value to AdminSet should probably be changed as well.
    laritakr committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    1765b0c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8af301e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ce28c4f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d65b3e3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b67ab72 View commit details
    Browse the repository at this point in the history
  7. Default Admin Set

    The config admin set class should not fall back to AdminSet, since
    the default admin set service cannot create an AdminSet.
    laritakr committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    280778e View commit details
    Browse the repository at this point in the history
  8. Modify collection spec for admin set changes

    Links for Admin sets in collection type dropdown have changed.
    laritakr committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    eee804f View commit details
    Browse the repository at this point in the history
  9. Fix create_admin_set_spec

    laritakr committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    55686ce View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. Fix admin set ability

    calling wrong method
    laritakr committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    9a46423 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1ba3651 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    322ac95 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    afe5117 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    db9ef1f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f07800f View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Fix a portion of admin_sets_controller_spec

    Shared specs are still failing.
    laritakr committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    03a8bb7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0bc9d89 View commit details
    Browse the repository at this point in the history
  3. Why, Rubocop?

    laritakr committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    a07540d View commit details
    Browse the repository at this point in the history
  4. Additional specs

    Base class on config for admin_set_model rather than the use_valkyrie flag
    laritakr committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    3ad9978 View commit details
    Browse the repository at this point in the history
  5. Oh Rubocop

    laritakr committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    e7a8a8f View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. Merge branch 'double_combo' into collections-and-admin-set-resources

    * double_combo:
      ☑️ Add stubbing
      🐛 Favor helper method over instance variable
      Extracting a collection models method
      💄 endless and ever appeasing of the coppers
      ♻️ Stub incidental query
      ♻️ Consider all of the curation concerns
    jeremyf committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    dde3a01 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7fe193d View commit details
    Browse the repository at this point in the history
  3. Add alias for create_any

    jeremyf committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    8390409 View commit details
    Browse the repository at this point in the history
  4. ☑️ Add stubbing

    jeremyf committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    2d30373 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0edd9a7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d5c6f68 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    ed9e1e7 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Configuration menu
    Copy the full SHA
    3fe9e18 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7ebd7cc View commit details
    Browse the repository at this point in the history
  3. 🧹 Fixing a spec

    jeremyf committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    9e4c35a View commit details
    Browse the repository at this point in the history
  4. ♻️ Extracting naming container

    Throughout the code we have quite a bit of conditionals regarding what
    is a work, collection, file_set, and adminsitrative set.  This model
    attempts to provide a common point to interrogate the application.
    
    There are, at present, no refactors to use this model.
    
    Consider how our specs and our application are inconsistent in their
    declaration/configuration/stubbing.  This model should help with that.
    jeremyf committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    84f5a36 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3fb6a89 View commit details
    Browse the repository at this point in the history
  6. ♻️ Favor Hyrax::ModelRegistry for search builders

    Instead of the myriad of ways of asking about which models to use, let's
    leverage a consolidated central place for information.
    
    This is but one step in addressing other issues.
    jeremyf committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    37827d3 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8fdc622 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. Configuration menu
    Copy the full SHA
    7276d9d View commit details
    Browse the repository at this point in the history
  2. Merge branch 'extract-hyrax-model-registry' into collections-and-admi…

    …n-set-resources
    
    * extract-hyrax-model-registry:
      🐛 Favor helper method over instance variable
      Favor helper method over instance variable
      ♻️ Favor dynamic value
      ♻️ Favor helper method
      ☑️ Fix stubbing
      Adding case statement
      ♻️ Fixing spec
      ♻️ Favor Hyrax::ModelRegistry
      💄 endless and ever appeasing of the coppers
      ♻️ Leverage Hyrax::ModelRegistry for ability tests
      ♻️ Favor Hyrax::ModelRegistry for search builders
      ♻️ Extracting naming container
      🧹 Expose Hyrax.config.use_valkyrie=
    jeremyf committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    5b329df View commit details
    Browse the repository at this point in the history