-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability and search fixes #6653
Ability and search fixes #6653
Commits on Feb 1, 2024
-
Use config variable for admin set in more places.
Configuration menu - View commit details
-
Copy full SHA for 4e91ab9 - Browse repository at this point
Copy the full SHA 4e91ab9View commit details -
Configuration menu - View commit details
-
Copy full SHA for c4722e5 - Browse repository at this point
Copy the full SHA c4722e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b5cf93 - Browse repository at this point
Copy the full SHA 8b5cf93View commit details
Commits on Feb 2, 2024
-
Address duplication in collection type dropdown
Admin Sets were appearing twice, once via their gid, and once via their model. This change moves them to work like other collections.
Configuration menu - View commit details
-
Copy full SHA for 40f2c0e - Browse repository at this point
Copy the full SHA 40f2c0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for bf33a9e - Browse repository at this point
Copy the full SHA bf33a9eView commit details -
Configuration menu - View commit details
-
Copy full SHA for c5ce8af - Browse repository at this point
Copy the full SHA c5ce8afView commit details -
Configuration menu - View commit details
-
Copy full SHA for b1e02ae - Browse repository at this point
Copy the full SHA b1e02aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for f20540f - Browse repository at this point
Copy the full SHA f20540fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f9458e - Browse repository at this point
Copy the full SHA 4f9458eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 897bbf8 - Browse repository at this point
Copy the full SHA 897bbf8View commit details
Commits on Feb 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 10dc1a3 - Browse repository at this point
Copy the full SHA 10dc1a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 447abf4 - Browse repository at this point
Copy the full SHA 447abf4View commit details
Commits on Feb 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f272c90 - Browse repository at this point
Copy the full SHA f272c90View commit details
Commits on Feb 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d21129e - Browse repository at this point
Copy the full SHA d21129eView commit details -
Lock down AdminSetCreateService class
The admin set create service cannot create an AdminSet. Changing to use the config variable causes specs to break, because they are using the default config value of AdminSet. This is the first step to locking down the change. The default fallback value to AdminSet should probably be changed as well.
Configuration menu - View commit details
-
Copy full SHA for 1765b0c - Browse repository at this point
Copy the full SHA 1765b0cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8af301e - Browse repository at this point
Copy the full SHA 8af301eView commit details -
Configuration menu - View commit details
-
Copy full SHA for ce28c4f - Browse repository at this point
Copy the full SHA ce28c4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d65b3e3 - Browse repository at this point
Copy the full SHA d65b3e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for b67ab72 - Browse repository at this point
Copy the full SHA b67ab72View commit details -
The config admin set class should not fall back to AdminSet, since the default admin set service cannot create an AdminSet.
Configuration menu - View commit details
-
Copy full SHA for 280778e - Browse repository at this point
Copy the full SHA 280778eView commit details -
Modify collection spec for admin set changes
Links for Admin sets in collection type dropdown have changed.
Configuration menu - View commit details
-
Copy full SHA for eee804f - Browse repository at this point
Copy the full SHA eee804fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 55686ce - Browse repository at this point
Copy the full SHA 55686ceView commit details
Commits on Feb 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9a46423 - Browse repository at this point
Copy the full SHA 9a46423View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ba3651 - Browse repository at this point
Copy the full SHA 1ba3651View commit details -
Configuration menu - View commit details
-
Copy full SHA for 322ac95 - Browse repository at this point
Copy the full SHA 322ac95View commit details -
Configuration menu - View commit details
-
Copy full SHA for afe5117 - Browse repository at this point
Copy the full SHA afe5117View commit details -
Configuration menu - View commit details
-
Copy full SHA for db9ef1f - Browse repository at this point
Copy the full SHA db9ef1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f07800f - Browse repository at this point
Copy the full SHA f07800fView commit details
Commits on Feb 9, 2024
-
Fix a portion of admin_sets_controller_spec
Shared specs are still failing.
Configuration menu - View commit details
-
Copy full SHA for 03a8bb7 - Browse repository at this point
Copy the full SHA 03a8bb7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0bc9d89 - Browse repository at this point
Copy the full SHA 0bc9d89View commit details -
Configuration menu - View commit details
-
Copy full SHA for a07540d - Browse repository at this point
Copy the full SHA a07540dView commit details -
Base class on config for admin_set_model rather than the use_valkyrie flag
Configuration menu - View commit details
-
Copy full SHA for 3ad9978 - Browse repository at this point
Copy the full SHA 3ad9978View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7a8a8f - Browse repository at this point
Copy the full SHA e7a8a8fView commit details
Commits on Feb 12, 2024
-
Merge branch 'double_combo' into collections-and-admin-set-resources
* double_combo: ☑️ Add stubbing 🐛 Favor helper method over instance variable Extracting a collection models method 💄 endless and ever appeasing of the coppers ♻️ Stub incidental query ♻️ Consider all of the curation concerns
Configuration menu - View commit details
-
Copy full SHA for dde3a01 - Browse repository at this point
Copy the full SHA dde3a01View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7fe193d - Browse repository at this point
Copy the full SHA 7fe193dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8390409 - Browse repository at this point
Copy the full SHA 8390409View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d30373 - Browse repository at this point
Copy the full SHA 2d30373View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0edd9a7 - Browse repository at this point
Copy the full SHA 0edd9a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for d5c6f68 - Browse repository at this point
Copy the full SHA d5c6f68View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed9e1e7 - Browse repository at this point
Copy the full SHA ed9e1e7View commit details
Commits on Feb 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3fe9e18 - Browse repository at this point
Copy the full SHA 3fe9e18View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ebd7cc - Browse repository at this point
Copy the full SHA 7ebd7ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e4c35a - Browse repository at this point
Copy the full SHA 9e4c35aView commit details -
♻️ Extracting naming container
Throughout the code we have quite a bit of conditionals regarding what is a work, collection, file_set, and adminsitrative set. This model attempts to provide a common point to interrogate the application. There are, at present, no refactors to use this model. Consider how our specs and our application are inconsistent in their declaration/configuration/stubbing. This model should help with that.
Configuration menu - View commit details
-
Copy full SHA for 84f5a36 - Browse repository at this point
Copy the full SHA 84f5a36View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3fb6a89 - Browse repository at this point
Copy the full SHA 3fb6a89View commit details -
♻️ Favor Hyrax::ModelRegistry for search builders
Instead of the myriad of ways of asking about which models to use, let's leverage a consolidated central place for information. This is but one step in addressing other issues.
Configuration menu - View commit details
-
Copy full SHA for 37827d3 - Browse repository at this point
Copy the full SHA 37827d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8fdc622 - Browse repository at this point
Copy the full SHA 8fdc622View commit details
Commits on Feb 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7276d9d - Browse repository at this point
Copy the full SHA 7276d9dView commit details -
Merge branch 'extract-hyrax-model-registry' into collections-and-admi…
…n-set-resources * extract-hyrax-model-registry: 🐛 Favor helper method over instance variable Favor helper method over instance variable ♻️ Favor dynamic value ♻️ Favor helper method ☑️ Fix stubbing Adding case statement ♻️ Fixing spec ♻️ Favor Hyrax::ModelRegistry 💄 endless and ever appeasing of the coppers ♻️ Leverage Hyrax::ModelRegistry for ability tests ♻️ Favor Hyrax::ModelRegistry for search builders ♻️ Extracting naming container 🧹 Expose Hyrax.config.use_valkyrie=
Configuration menu - View commit details
-
Copy full SHA for 5b329df - Browse repository at this point
Copy the full SHA 5b329dfView commit details