🐛 Remove subtle timing error in ActorStack coercion #6670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the order of operations was: 1. Coerce the curation_concern to a valkyrie_resource 2. Save the curation concern The subtle bug is that the curation_concern's valkyrie resource would have an out of sync access control. Why, because we're relying on logic elsewhere (e.g. Hyrax::ModelConverter) to assign the permissions. In v5.0.0 and prior we're copying the current curation concern's permissions to the valkyrie permission; this happens before we save. [See implementation][1]. However, this can create issues depending on metadata adapter configuration; in particular when we update the ACL object for a record without updating the record; something that we see happening in the Frigg and Freyja adapters, but is also not limited to those adapters. Also, consider that we likely want to remove a timing of parameters; because when reading method call, we (or at least I) mentally treat the parameters we pass as order independent. Put another way, the parameters we pass should likely not change state of each other. [1]: bcf3ab0
dlpierce
approved these changes
Feb 6, 2024
jeremyf
added a commit
that referenced
this pull request
Feb 6, 2024
Prior to this commit we relied on the access_control object to "self
convert" via the `#valkyrie_resource` method. However, that method
circumvents the `Hyrax.query_service` which provides a more up to date
version of the permissions.
This is subtle bug is most notable when we have composite adapters;
those modeled in the `double_combo` branch.
How it manifests is as follows:
- I have a Work and ACL in Fedora.
- I update the ACL to Postgres.
- When I fetch the Work, it's in Fedora and grabs the ACL from Fedora
which is not the most current.
This relates to:
- 0de7df6
- #6670
jeremyf
added a commit
that referenced
this pull request
Feb 6, 2024
Prior to this commit we relied on the access_control object to "self
convert" via the `#valkyrie_resource` method. However, that method
circumvents the `Hyrax.query_service` which provides a more up to date
version of the permissions.
This is subtle bug is most notable when we have composite adapters;
those modeled in the `double_combo` branch.
How it manifests is as follows:
- I have a Work and ACL in Fedora.
- I update the ACL to Postgres.
- When I fetch the Work, it's in Fedora and grabs the ACL from Fedora
which is not the most current.
This relates to:
- 0de7df6
- #6670
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the order of operations was:
env.curation_concern.valkyrie_resource)The subtle bug is that the curation_concern's valkyrie resource would have an out of sync access control. Why, because we're relying on logic elsewhere (e.g. Hyrax::ModelConverter) to assign the permissions.
In v5.0.0 and prior we're copying the current curation concern's permissions to the valkyrie permission; this happens before we save. See implementation.
However, this can create issues depending on metadata adapter configuration; in particular when we update the ACL object for a record without updating the record; something that we see happening in the Frigg and Freyja adapters, but is also not limited to those adapters.
Also, consider that we likely want to remove a timing of parameters; because when reading method call, we (or at least I) mentally treat the parameters we pass as order independent. Put another way, the parameters we pass should likely not change state of each other.
@samvera/hyrax-code-reviewers